Skip to content

Conversation

@astefan
Copy link
Contributor

@astefan astefan commented Mar 27, 2019

This PR adds documentation for MATCH and QUERY function predicates, updates the Functions & Operators page to include the list of all available functions and polishes (&rearranges) some of the other functions pages.

Fixes #35076.
Fixes #36885.

astefan added 2 commits March 27, 2019 02:17
Polish the functions pages and add a list of functions to the main
Functions & Operators page.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

@astefan astefan changed the title 35076 fix SQL: MATCH and QUERY documentation; one list of functions Mar 27, 2019
Copy link
Member

@costin costin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work!
My only comment would be to add a comment to LIKE and RLIKE section mentioning the advantages of full-text queries: faster, more powerful and accurate.

include-tagged::{sql-specs}/docs/docs.csv-spec[simpleMatch]
----

However, it can also receive a list of fields and their corresponding optional `boost` value. In this case, {es-sql} will use a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a basic explanation on boosting does in this example for SQL folks that might be familiar with it.

additional configuration parameters (separated by semicolon `;`) for either `match` or `multi_match` queries. For example:

["source","sql",subs="attributes,callouts,macros"]
----
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here - explain what the example tries to achieve.


{es-sql} provides a comprehensive set of built-in operators and functions:

* <<sql-operators, Operators>>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@astefan
Copy link
Contributor Author

astefan commented Mar 27, 2019

@costin I've created #40508 for completing LIKE/RLIKE docs sections.

Copy link
Contributor

@matriv matriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great work here!

@astefan astefan merged commit 4cec0ae into elastic:master Mar 27, 2019
@astefan astefan deleted the 35076_fix branch March 27, 2019 15:18
astefan added a commit that referenced this pull request Mar 27, 2019
* Document MATCH and QUERY function predicates.
* Polish the functions pages and add a list of functions to the main Functions & Operators page.

(cherry picked from commit 4cec0ae)
astefan added a commit that referenced this pull request Mar 28, 2019
* Document MATCH and QUERY function predicates.
* Polish the functions pages and add a list of functions to the main Functions & Operators page.

(cherry picked from commit 4cec0ae)
astefan added a commit that referenced this pull request Mar 28, 2019
* Document MATCH and QUERY function predicates.
* Polish the functions pages and add a list of functions to the main Functions & Operators page.

(cherry picked from commit 4cec0ae)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SQL: Make a one-page list of all implemented functions SQL: document the MATCH and QUERY full-text queries

5 participants