Skip to content

SQL: Add missing handling of IP field in JDBC #40384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
costin merged 1 commit into from
Mar 23, 2019
Merged

SQL: Add missing handling of IP field in JDBC #40384

costin merged 1 commit into from
Mar 23, 2019

Conversation

@costin
Copy link
Member

@costin costin commented Mar 22, 2019

Fix #40358

@costin costin requested review from astefan and matriv March 22, 2019 21:22
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 22, 2019

Pinging @elastic/es-search

@matriv
Copy link
Contributor

matriv commented Mar 22, 2019

@elasticmachine run elasticsearch-ci/1

matriv
matriv approved these changes Mar 22, 2019
View reviewed changes
Copy link
Contributor

@matriv matriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

astefan
astefan approved these changes Mar 23, 2019
View reviewed changes
Copy link
Contributor

@astefan astefan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@costin costin merged commit ee286fa into elastic:master Mar 23, 2019
@costin costin deleted the fix-40358 branch March 23, 2019 10:41
costin added a commit that referenced this pull request Mar 23, 2019
@costin
SQL: Add missing handling of IP field in JDBC (#40384)
558adc0 
Fix #40358

(cherry picked from commit ee286fa)
(cherry picked from commit d229624)
costin added a commit that referenced this pull request Mar 23, 2019
@costin
SQL: Add missing handling of IP field in JDBC (#40384)
daf97ce 
Fix #40358

(cherry picked from commit ee286fa)
(cherry picked from commit d229624)
costin added a commit that referenced this pull request Mar 23, 2019
@costin
SQL: Add missing handling of IP field in JDBC (#40384)
8ea08df 
Fix #40358

(cherry picked from commit ee286fa)
(cherry picked from commit d229624)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@astefan astefan astefan approved these changes

+1 more reviewer

@matriv matriv matriv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

:Analytics/SQL SQL querying >bug v6.6.3 v6.7.1 v7.0.0-rc1 v7.2.0 v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SQL: IP fields tests

6 participants

@costin @elasticmachine @matriv @astefan @jakelandis @michaelbaamonde