Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Update Windows command to support prettified JSON licenses #40375

Merged
merged 1 commit into from
Mar 25, 2019
Merged

[DOCS] Update Windows command to support prettified JSON licenses #40375

merged 1 commit into from
Mar 25, 2019

Conversation

jrodewig
Copy link
Contributor

Without extra parameters, gc does not support licenses in prettified JSON.

Per @eskibars' s suggestion, this updates the command to use the -InFile parameter of PowerShell's Invoke-WebRequest. This removes the need for gc entirely.

Resolves #40139

@jrodewig jrodewig added >docs General docs changes v7.0.0 :Security/License License functionality for commercial features v8.0.0 v7.2.0 labels Mar 22, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security

@jrodewig jrodewig changed the title Update Windows command to support prettified JSON licenses [DOCS] Update Windows command to support prettified JSON licenses Mar 22, 2019
jasontedor
jasontedor approved these changes Mar 22, 2019
View reviewed changes
Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jrodewig jrodewig merged commit 5bbdc80 into elastic:master Mar 25, 2019
@jrodewig jrodewig deleted the update-win-lic branch March 25, 2019 12:40
@danielharada danielharada mentioned this pull request Apr 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasontedor jasontedor jasontedor approved these changes

@debadair debadair Awaiting requested review from debadair

@eskibars eskibars Awaiting requested review from eskibars

@kat257 kat257 Awaiting requested review from kat257

Assignees
No one assigned
Labels
>docs General docs changes :Security/License License functionality for commercial features v7.0.0-rc2 v7.2.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

License update docs can lead to parsing errors on Windows
4 participants
@jrodewig @elasticmachine @jasontedor @jakelandis