Skip to content

[ML][TEST] Fix failing test testPersistJobOnGracefulShutdown_givenTim… #40363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
droberts195 merged 2 commits into from
Mar 25, 2019
Merged

[ML][TEST] Fix failing test testPersistJobOnGracefulShutdown_givenTim… #40363

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80b24f9
[ML][TEST] Fix failing test testPersistJobOnGracefulShutdown_givenTim…
edsavage Mar 22, 2019
d02e5d0
Merge branch 'master' into bugfix/test_persist_time_advanced_after_no…
Mar 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions ...e-multi-node-tests/src/test/java/org/elasticsearch/xpack/ml/integration/PersistJobIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ public void testPersistJob() throws Exception {
}

// check that state is persisted after time has been advanced even if no new data is seen in the interim
@AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/40347")
public void testPersistJobOnGracefulShutdown_givenTimeAdvancedAfterNoNewData() throws Exception {
String jobId = "time-advanced-after-no-new-data-test";

Expand All @@ -60,6 +59,7 @@ public void testPersistJobOnGracefulShutdown_givenTimeAdvancedAfterNoNewData() t
FlushJobAction.Response flushResponse = flushJob(jobId, true);

closeJob(jobId);
long job1CloseTime = System.currentTimeMillis() / 1000;

// Check that state has been persisted
SearchResponse stateDocsResponse1 = client().prepareSearch(AnomalyDetectorsIndex.jobStateIndexPattern())
Expand All @@ -71,7 +71,7 @@ public void testPersistJobOnGracefulShutdown_givenTimeAdvancedAfterNoNewData() t
int numQuantileRecords = 0;
int numStateRecords = 0;
for (SearchHit hit : stateDocsResponse1.getHits().getHits()) {
logger.info(hit.getId());
logger.info("1: " + hit.getId());
if (hit.getId().contains("quantiles")) {
++numQuantileRecords;
} else if (hit.getId().contains("model_state")) {
Expand All @@ -82,6 +82,13 @@ public void testPersistJobOnGracefulShutdown_givenTimeAdvancedAfterNoNewData() t
assertThat(numQuantileRecords, equalTo(1));
assertThat(numStateRecords, equalTo(1));

// To generate unique snapshot IDs ensure that there is at least a 1s delay between the
// time each job was closed
assertBusy(() -> {
long timeNow = System.currentTimeMillis() / 1000;
assertFalse(job1CloseTime >= timeNow);
});

// re-open the job
openJob(jobId);

Expand All @@ -104,7 +111,7 @@ public void testPersistJobOnGracefulShutdown_givenTimeAdvancedAfterNoNewData() t
numQuantileRecords = 0;
numStateRecords = 0;
for (SearchHit hit : stateDocsResponse2.getHits().getHits()) {
logger.info(hit.getId());
logger.info("2: " + hit.getId());
if (hit.getId().contains("quantiles")) {
++numQuantileRecords;
} else if (hit.getId().contains("model_state")) {
Expand Down