SQL: Fix RLIKE bug and improve testing for RLIKE statement #40354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add integration tests for RLIKE * Polish the rest of tests
Collaborator
|
Pinging @elastic/es-search |
astefan
changed the title
Contributor
Author
|
@elasticmachine run elasticsearch-ci/packaging-sample |
1 similar comment
Contributor
Author
|
@elasticmachine run elasticsearch-ci/packaging-sample |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/packaging-sample |
astefan
added a commit
that referenced
this pull request
Mar 23, 2019
* Refactor RegexMatch to support both LIKE and RLIKE * Add integration tests for RLIKE * Polish the rest of tests (cherry picked from commit 7562d6e)
astefan
added a commit
that referenced
this pull request
Mar 23, 2019
* Refactor RegexMatch to support both LIKE and RLIKE * Add integration tests for RLIKE * Polish the rest of tests (cherry picked from commit 7562d6e)
astefan
added a commit
that referenced
this pull request
Mar 23, 2019
* Refactor RegexMatch to support both LIKE and RLIKE * Add integration tests for RLIKE * Polish the rest of tests (cherry picked from commit 7562d6e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly fixes a bug similar with #39931 (but for RLIKE statement) by slightly refactoring RegexMatch/Like/RLike classes and adds integration tests for RLIKE.
Fixes #34609.