Don't emit deprecation warnings on calls to the monitoring bulk API. (#39805)#39843
Merged
jpountz merged 2 commits intoelastic:7.0from Mar 11, 2019
Merged
Don't emit deprecation warnings on calls to the monitoring bulk API. (#39805)#39843jpountz merged 2 commits intoelastic:7.0from
jpountz merged 2 commits intoelastic:7.0from
Conversation
…lastic#39805) The monitoring bulk API accepts the same format as the bulk API, yet its concept of types is different from "mapping types" and the deprecation warning is only emitted as a side-effect of this API reusing the parsing logic of bulk requests. This commit extracts the parsing logic from `_bulk` into its own class with a new flag that allows to configure whether usage of `_type` should emit a warning or not. Support for payloads has been removed for simplicity since they were unused. @jakelandis has a separate change that removes this notion of type from the monitoring bulk API that we are considering bringing to 8.0.
hub-cap
pushed a commit
that referenced
this pull request
May 4, 2019
Removing of payload in BulkRequest (#39843) had a side effect of making `BulkRequest.add(DocWriteRequest<?>...)` (with varargs) recursive, thus leading to StackOverflowError. This PR adds a small change in RequestConvertersTests to show the error and the corresponding fix in `BulkRequest`. Fixes #41668
hub-cap
pushed a commit
to hub-cap/elasticsearch
that referenced
this pull request
May 22, 2019
Removing of payload in BulkRequest (elastic#39843) had a side effect of making `BulkRequest.add(DocWriteRequest<?>...)` (with varargs) recursive, thus leading to StackOverflowError. This PR adds a small change in RequestConvertersTests to show the error and the corresponding fix in `BulkRequest`. Fixes elastic#41668
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
Removing of payload in BulkRequest (elastic#39843) had a side effect of making `BulkRequest.add(DocWriteRequest<?>...)` (with varargs) recursive, thus leading to StackOverflowError. This PR adds a small change in RequestConvertersTests to show the error and the corresponding fix in `BulkRequest`. Fixes elastic#41668
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The monitoring bulk API accepts the same format as the bulk API, yet its concept
of types is different from "mapping types" and the deprecation warning is only
emitted as a side-effect of this API reusing the parsing logic of bulk requests.
This commit extracts the parsing logic from
_bulkinto its own class with anew flag that allows to configure whether usage of
_typeshould emit a warningor not. Support for payloads has been removed for simplicity since they were
unused.
@jakelandis has a separate change that removes this notion of type from the
monitoring bulk API that we are considering bringing to 8.0.