Correct rebuilt persian analyzer (#38724) #38744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make substitution of \u200C with a space explicit The problem with this symbol `\u200C` in a test string, that **SHOULD** be substituted with space in the rebuilt Persian analyzer, but it is not. Correcting this line `"mappings": [ "\\u200C=> "] <1>` to `"mappings": [ "\\u200C=>\\u0020"] <1>` in solves the problem. This change explicitly says to substitute ZWNJ with a space. Closes elastic#38188
benwtrent
pushed a commit
to benwtrent/elasticsearch
that referenced
this pull request
Feb 21, 2019
Make substitution of \u200C with a space explicit The problem with this symbol `\u200C` in a test string, that **SHOULD** be substituted with space in the rebuilt Persian analyzer, but it is not. Correcting this line `"mappings": [ "\\u200C=> "] <1>` to `"mappings": [ "\\u200C=>\\u0020"] <1>` in solves the problem. This change explicitly says to substitute ZWNJ with a space. Closes elastic#38188
benwtrent
added a commit
that referenced
this pull request
Feb 21, 2019
Make substitution of \u200C with a space explicit The problem with this symbol `\u200C` in a test string, that **SHOULD** be substituted with space in the rebuilt Persian analyzer, but it is not. Correcting this line `"mappings": [ "\\u200C=> "] <1>` to `"mappings": [ "\\u200C=>\\u0020"] <1>` in solves the problem. This change explicitly says to substitute ZWNJ with a space. Closes #38188
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make substitution of \u200C with a space explicit
The problem with this symbol
\u200Cin a test string,that SHOULD be substituted with space in the rebuilt Persian analyzer, but it is not.
Correcting this line
"mappings": [ "\\u200C=> "] <1>to"mappings": [ "\\u200C=>\\u0020"] <1>in solves the problem.This change explicitly says to substitute ZWNJ with a space.
backport for #38724
Closes #38188