Skip to content

Conversation

@costin
Copy link
Member

@costin costin commented Feb 9, 2019

No description provided.

@costin
Copy link
Member Author

costin commented Feb 9, 2019

@elasticmachine run elasticsearch-ci/docbldesx

1 similar comment
@costin
Copy link
Member Author

costin commented Feb 9, 2019

@elasticmachine run elasticsearch-ci/docbldesx

Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, this is a fun one. When I built these changes locally, I got a long list of gibberish in my error. The important part is this line: /Users/brandonmorelli/Documents/GitHub/elasticsearch/html_docs/index.xml:101739: element section: validity error

Taking a look at line 101739 in index.xml, I saw the error was occurring on a line with the word Functions in it. Above that line was the term "Basic arithmetic operators". Searched for that term in the documentation and it led me to the date-time.asciidoc file. Sure enough, we can scroll to the Functions section and see the problem.

Here's what this looked like before:

==== Functions

beta[]

[[sql-functions-current-date]]
==== `CURRENT_DATE/CURDATE`

And now it looks like:

==== Functions

[[sql-functions-current-date]]
==== `CURRENT_DATE/CURDATE`

It's a subtle problem, but you can't have an empty space between headers of the same level. You need to put something between ==== Functions and ==== CURRENT_DATE/CURDATE. Once you do that, the docs built just fine for me!


==== Functions

beta[]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the problem. You have two headings of the same level with no content between them. Something needs to go in this space here. When I put a comment here: //comment, the docs built for me.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers!

+
This setting is equivalent to the previous one, with one additional check against certificate's revocation. This offers the strongest
security option and is the recommended setting for production deployments.
security option and is the recommended setting for odbcion deployments.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small replacement failure.

@costin costin merged commit fb6e7a3 into elastic:master Feb 9, 2019
costin added a commit that referenced this pull request Feb 9, 2019
@costin costin deleted the doc/updates branch February 9, 2019 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants