-
Notifications
You must be signed in to change notification settings - Fork 25.7k
SQL: remove beta marker from documentation #38661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@elasticmachine run elasticsearch-ci/docbldesx |
1 similar comment
|
@elasticmachine run elasticsearch-ci/docbldesx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, this is a fun one. When I built these changes locally, I got a long list of gibberish in my error. The important part is this line: /Users/brandonmorelli/Documents/GitHub/elasticsearch/html_docs/index.xml:101739: element section: validity error
Taking a look at line 101739 in index.xml, I saw the error was occurring on a line with the word Functions in it. Above that line was the term "Basic arithmetic operators". Searched for that term in the documentation and it led me to the date-time.asciidoc file. Sure enough, we can scroll to the Functions section and see the problem.
Here's what this looked like before:
==== Functions
beta[]
[[sql-functions-current-date]]
==== `CURRENT_DATE/CURDATE`
And now it looks like:
==== Functions
[[sql-functions-current-date]]
==== `CURRENT_DATE/CURDATE`
It's a subtle problem, but you can't have an empty space between headers of the same level. You need to put something between ==== Functions and ==== CURRENT_DATE/CURDATE. Once you do that, the docs built just fine for me!
|
|
||
| ==== Functions | ||
|
|
||
| beta[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the problem. You have two headings of the same level with no content between them. Something needs to go in this space here. When I put a comment here: //comment, the docs built for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cheers!
| + | ||
| This setting is equivalent to the previous one, with one additional check against certificate's revocation. This offers the strongest | ||
| security option and is the recommended setting for production deployments. | ||
| security option and is the recommended setting for odbcion deployments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small replacement failure.
(cherry picked from commit fb6e7a3)
No description provided.