Closed
Conversation
Fallback settings were introduced in elastic#33413 where the `search.remote.*` settings were generalized to `cluster.remote.*`. This commit removes both the fallback settings and the upgraders that were introduced in elastic#33537
jkakavas
added
>non-issue
:Distributed/CCR
Collaborator
|
Pinging @elastic/es-distributed |
jkakavas
commented
Feb 7, 2019
| assertSettingDeprecationsAndWarnings(new String[]{"search.remote.quux.seeds", "search.remote.quux.proxy"}); | ||
| } | ||
|
|
||
| public void testBuildRemoteClustersDynamicConfigWithDuplicate() { |
Contributor
Author
There was a problem hiding this comment.
I think these were not needed any more now that we don't have both cluster.remote and search.remote settings to account for but we can reintroduce duplication validation if need be in RemoteClusterAware.java
Member
There was a problem hiding this comment.
correct, we don't need this anymore.
javanna
approved these changes
Feb 7, 2019
| assertSettingDeprecationsAndWarnings(new String[]{"search.remote.quux.seeds", "search.remote.quux.proxy"}); | ||
| } | ||
|
|
||
| public void testBuildRemoteClustersDynamicConfigWithDuplicate() { |
Member
There was a problem hiding this comment.
correct, we don't need this anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fallback settings were introduced in #33413 where the
search.remote.*settings were generalized tocluster.remote.*.This commit removes both the fallback settings and the upgraders
that were introduced in #33537