Skip to content

Remove empty service files #38192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2019
Merged

Remove empty service files #38192

merged 1 commit into from
Feb 4, 2019

Conversation

@alpar-t
Copy link
Contributor

@alpar-t alpar-t commented Feb 1, 2019

Relates to #28984.

@alpar-t alpar-t requested review from jasontedor and rjernst February 1, 2019 14:51
jasontedor
jasontedor approved these changes Feb 1, 2019
View reviewed changes
Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@alpar-t alpar-t merged commit d58e899 into elastic:master Feb 4, 2019
@alpar-t alpar-t deleted the remove-empty-service-files branch February 4, 2019 08:05
This was referenced Feb 4, 2019
Merged
Closed
alpar-t added a commit that referenced this pull request Feb 5, 2019
@alpar-t
Remove empty service files (#38192) (#38300)
6600806
@tomdw
Copy link

tomdw commented Feb 5, 2019

@atotork I think
https://github.com/elastic/elasticsearch/blob/master/server/src/main/resources/META-INF/services/org.apache.lucene.codecs.PostingsFormat should have been removed also as the impl class and package is not present in the elasticsearch jar

@namannigam-zz
Copy link

namannigam-zz commented Sep 26, 2019 •
edited
Loading

@tomdw or one may probably face

Provider class org.apache.lucene.search.suggest.document.Completion50PostingsFormat not in module

as in this SO question

Was there an alternate solution to that?

@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasontedor jasontedor jasontedor approved these changes

@rjernst rjernst Awaiting requested review from rjernst

Assignees

No one assigned

Labels

:Delivery/Build Build or test infrastructure >non-issue Team:Delivery Meta label for Delivery team v6.7.0 v7.0.0-beta1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@alpar-t @tomdw @namannigam-zz @jasontedor @colings86 @mark-vieira