Skip to content

Add anchor to doc link in old index check #37724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gwbrown merged 2 commits into from
Jan 23, 2019
Merged

Add anchor to doc link in old index check #37724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bcb75e
Add anchor to doc link in old index check
gwbrown Jan 22, 2019
b52e474
Merge branch '6.x' into depcheck/improve-doc-link
gwbrown Jan 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...deprecation/src/main/java/org/elasticsearch/xpack/deprecation/IndexDeprecationChecks.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,8 @@ static DeprecationIssue oldIndicesCheck(IndexMetaData indexMetaData) {
} else {
return new DeprecationIssue(DeprecationIssue.Level.CRITICAL,
"Index created before 6.0",
"https://www.elastic.co/guide/en/elasticsearch/reference/master/" +
"breaking-changes-7.0.html",
"https://www.elastic.co/guide/en/elasticsearch/reference/master/breaking-changes-7.0.html" +
"#_indices_created_before_7_0",
"This index was created using version: " + createdWith);
}

Expand Down
8 changes: 4 additions & 4 deletions ...cation/src/test/java/org/elasticsearch/xpack/deprecation/IndexDeprecationChecksTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ public void testOldIndicesCheck() {
.build();
DeprecationIssue expected = new DeprecationIssue(DeprecationIssue.Level.CRITICAL,
"Index created before 6.0",
"https://www.elastic.co/guide/en/elasticsearch/reference/master/" +
"breaking-changes-7.0.html",
"https://www.elastic.co/guide/en/elasticsearch/reference/master/breaking-changes-7.0.html" +
"#_indices_created_before_7_0",
"This index was created using version: " + createdWith);
List<DeprecationIssue> issues = DeprecationChecks.filterChecks(INDEX_SETTINGS_CHECKS, c -> c.apply(indexMetaData));
assertEquals(singletonList(expected), issues);
Expand Down Expand Up @@ -73,8 +73,8 @@ public void testMultipleTypesCheckWithDefaultMapping() throws IOException {

DeprecationIssue expected = new DeprecationIssue(DeprecationIssue.Level.CRITICAL,
"Index created before 6.0",
"https://www.elastic.co/guide/en/elasticsearch/reference/master/" +
"breaking-changes-7.0.html",
"https://www.elastic.co/guide/en/elasticsearch/reference/master/breaking-changes-7.0.html" +
"#_indices_created_before_7_0",
"This index was created using version: " + createdWith);
List<DeprecationIssue> issues = DeprecationChecks.filterChecks(INDEX_SETTINGS_CHECKS, c -> c.apply(indexMetaData));
assertEquals(singletonList(expected), issues);
Expand Down