Report terms and version if cluster does not form #37473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the node's current term and the term and version of the the last-accepted cluster state to the message reported by the `ClusterFormationFailureHelper`, since these values may be of importance when tracking down a cluster formation failure.
DaveCTurner
added
>enhancement
v7.0.0
:Distributed Coordination/Cluster Coordination
Collaborator
|
Pinging @elastic/es-distributed |
ywelsch
approved these changes
Jan 15, 2019
| "discovery will continue using %s from hosts providers and %s from last-known cluster state", | ||
| resolvedAddresses, clusterStateNodes); | ||
| "discovery will continue using %s from hosts providers and %s from last-known cluster state; " + | ||
| "node term %d, last-accepted version %d in term %d", |
Contributor
There was a problem hiding this comment.
nit: perhaps last-accepted *cluster state* version in term
Contributor
Author
There was a problem hiding this comment.
😐 we just mentioned the cluster state, this message is already very long, and I don't think it will be misinterpreted as a different kind of version as it is. I left it alone.
DaveCTurner
deleted the
2018-01-15-more-details-in-clusterformationfailurehelper
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the node's current term and the term and version of the the last-accepted
cluster state to the message reported by the
ClusterFormationFailureHelper,since these values may be of importance when tracking down a cluster formation
failure.