Link to the SAML troubleshooting doc from guide #36754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly call out the existence of the troubleshooting guide so that hopefully users can solve common and easy problems with their initial configuration
jkakavas
added
>docs
Collaborator
|
Pinging @elastic/es-security |
Contributor
Author
|
@elasticmachine run the gradle build tests 2 |
lcawl
reviewed
Dec 18, 2018
Co-Authored-By: jkakavas <[email protected]>
…ticsearch into saml-guide-troubleshooting
tvernum
approved these changes
Dec 19, 2018
Contributor
tvernum
left a comment
tvernum
left a comment
There was a problem hiding this comment.
LGTM, except I think the link is wrong.
| specific configuration to be satisfied. | ||
| A conscious effort has been made to mask this complexity with sane defaults and the detailed | ||
| documentation above but in case you encounter issues while configuring a SAML realm, you can | ||
| look through our {stack-ov}/saml-guide.html[SAML troubleshooting documentation] that has |
Contributor
There was a problem hiding this comment.
Is that the right link? Don't you want to link to trb-security-saml.html?
Contributor
Author
There was a problem hiding this comment.
doh !yeah, an infinite doc loop is not what I had in mind :) thanks for noticing
lcawl
reviewed
Dec 19, 2018
Fix -for real now - the link URL Co-Authored-By: jkakavas <[email protected]>
Contributor
Author
|
@elasticmachine run the default distro tests σε παρακαλώ |
jkakavas
added a commit
that referenced
this pull request
Dec 20, 2018
Explicitly call out the existence of the troubleshooting guide so that hopefully users can solve common and easy problems with their initial configuration
jkakavas
added a commit
that referenced
this pull request
Dec 20, 2018
Explicitly call out the existence of the troubleshooting guide so that hopefully users can solve common and easy problems with their initial configuration
jkakavas
added a commit
that referenced
this pull request
Dec 20, 2018
Explicitly call out the existence of the troubleshooting guide so that hopefully users can solve common and easy problems with their initial configuration
jkakavas
added a commit
that referenced
this pull request
Dec 20, 2018
Explicitly call out the existence of the troubleshooting guide so that hopefully users can solve common and easy problems with their initial configuration
jkakavas
added a commit
that referenced
this pull request
Dec 20, 2018
Explicitly call out the existence of the troubleshooting guide so that hopefully users can solve common and easy problems with their initial configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly call out the existence of the troubleshooting guide so
that hopefully users can solve common and easy problems with their
initial configuration