[Zen2] Reduce cluster scope in NodeDisconnectIT #36168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test suite can stop all the shared master-eligible nodes, which breaks the cluster since any non-shared master-eligible nodes are stopped first in the reset process between tests. Since this test suite can leave the cluster in this somewhat broken state, it seems best that it uses a new cluster for each test.
DaveCTurner
added
>test
ywelsch
approved these changes
Dec 3, 2018
| wipePendingDataDirectories(); | ||
| } | ||
|
|
||
| assert nodes.isEmpty() || nodes.values().stream().anyMatch(NodeAndClient::isMasterEligible) |
Contributor
There was a problem hiding this comment.
can you use assertTrue here so that this does not only fail when assertions are enabled?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test suite can stop all the shared master-eligible nodes, which breaks the
cluster since any non-shared master-eligible nodes are stopped first in the
reset process between tests.
Since this test suite can leave the cluster in this somewhat broken state, it
seems best that it uses a new cluster for each test.