-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate /_xpack/monitoring/* in favor of /_monitoring/* #36130
Deprecate /_xpack/monitoring/* in favor of /_monitoring/* #36130
Conversation
This commit is part of our plan to deprecate and ultimately remove the use of _xpack in the REST APIs. * Add deprecation for /_xpack/monitoring/* in favor of /monitoring/* * Removed xpack from the rest-api-spec and tests * Removed xpack from the Action name * Removed MonitoringRestHandler as an unnecessary abstraction * Minor corrections to comments Relates elastic#35958
Pinging @elastic/es-core-infra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a comment to the naming.
...g/src/main/java/org/elasticsearch/xpack/monitoring/rest/action/RestMonitoringBulkAction.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good now. Left a few minor comments.
...g/src/main/java/org/elasticsearch/xpack/monitoring/rest/action/RestMonitoringBulkAction.java
Outdated
Show resolved
Hide resolved
...g/src/main/java/org/elasticsearch/xpack/monitoring/rest/action/RestMonitoringBulkAction.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This commit is part of our plan to deprecate and ultimately remove the use of _xpack in the REST APIs. * Add deprecation for /_xpack/monitoring/_bulk in favor of /_monitoring/bulk * Removed xpack from the rest-api-spec and tests * Removed xpack from the Action name * Removed MonitoringRestHandler as an unnecessary abstraction * Minor corrections to comments Relates #35958
This commit changes /_xpack/monitoring/_bulk to /_monitoring/bulk. The former is deprecrated as 7.0.0. Relates elastic/elasticsearch#36130 Relates elastic/elasticsearch#35958
This commit changes /_xpack/monitoring/_bulk to /_monitoring/bulk. The former is deprecrated as 7.0.0. Relates elastic/elasticsearch#36130 Relates elastic/elasticsearch#35958
This commit changes /_xpack/monitoring/_bulk to /_monitoring/bulk. The former is deprecrated as 7.0.0. Relates elastic/elasticsearch#36130 Relates elastic/elasticsearch#35958 Fixes #10528
This commit changes /_xpack/monitoring/_bulk to /_monitoring/bulk. The former is deprecrated as 7.0.0. Relates elastic/elasticsearch#36130 Relates elastic/elasticsearch#35958 Fixes #10528
This commit changes /_xpack/monitoring/_bulk to /_monitoring/bulk. The former is deprecrated as 7.0.0. Relates elastic/elasticsearch#36130 Relates elastic/elasticsearch#35958 Fixes #10528
This commit is part of our plan to deprecate and ultimately remove the
use of _xpack in the REST APIs.
Relates #35958
Note - since this is an internal API there is not an associated HLRC or docs. Also, i removed a comment a
/_xpack/monitoring/_setup
endpoint... I assume that is a stale comment since I can not find that endpoint.