Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate /_xpack/monitoring/* in favor of /_monitoring/* #36130

Merged
merged 3 commits into from
Dec 3, 2018

Conversation

jakelandis
Copy link
Contributor

@jakelandis jakelandis commented Nov 30, 2018

This commit is part of our plan to deprecate and ultimately remove the
use of _xpack in the REST APIs.

  • Add deprecation for /_xpack/monitoring/_bulk in favor of /_monitoring/bulk
  • Removed xpack from the rest-api-spec and tests
  • Removed xpack from the Action name
  • Removed MonitoringRestHandler as an unnecessary abstraction
  • Minor corrections to comments

Relates #35958


Note - since this is an internal API there is not an associated HLRC or docs. Also, i removed a comment a /_xpack/monitoring/_setup endpoint... I assume that is a stale comment since I can not find that endpoint.

This commit is part of our plan to deprecate and ultimately remove the
use of _xpack in the REST APIs.

* Add deprecation for /_xpack/monitoring/* in favor of /monitoring/*
* Removed xpack from the rest-api-spec and tests
* Removed xpack from the Action name
* Removed MonitoringRestHandler as an unnecessary abstraction
* Minor corrections to comments

Relates elastic#35958
@jakelandis jakelandis added :Core/Infra/REST API REST infrastructure and utilities >deprecation v7.0.0 labels Nov 30, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment to the naming.

@jakelandis jakelandis changed the title Deprecate /_xpack/monitoring/* in favor of /monitoring/* Deprecate /_xpack/monitoring/* in favor of /_monitoring/* Dec 2, 2018
Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good now. Left a few minor comments.

Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jakelandis jakelandis merged commit f8f521b into elastic:master Dec 3, 2018
spinscale pushed a commit that referenced this pull request Dec 4, 2018
This commit is part of our plan to deprecate and ultimately remove the
use of _xpack in the REST APIs.

* Add deprecation for /_xpack/monitoring/_bulk in favor of /_monitoring/bulk
* Removed xpack from the rest-api-spec and tests
* Removed xpack from the Action name
* Removed MonitoringRestHandler as an unnecessary abstraction
* Minor corrections to comments

Relates #35958
jakelandis added a commit to jakelandis/logstash that referenced this pull request Mar 10, 2019
This commit changes /_xpack/monitoring/_bulk to /_monitoring/bulk.
The former is deprecrated as 7.0.0.

Relates elastic/elasticsearch#36130
Relates elastic/elasticsearch#35958
jakelandis added a commit to jakelandis/logstash that referenced this pull request Mar 11, 2019
This commit changes /_xpack/monitoring/_bulk to /_monitoring/bulk.
The former is deprecrated as 7.0.0.

Relates elastic/elasticsearch#36130
Relates elastic/elasticsearch#35958
elasticsearch-bot pushed a commit to elastic/logstash that referenced this pull request Mar 12, 2019
This commit changes /_xpack/monitoring/_bulk to /_monitoring/bulk.
The former is deprecrated as 7.0.0.

Relates elastic/elasticsearch#36130
Relates elastic/elasticsearch#35958

Fixes #10528
elasticsearch-bot pushed a commit to elastic/logstash that referenced this pull request Mar 12, 2019
This commit changes /_xpack/monitoring/_bulk to /_monitoring/bulk.
The former is deprecrated as 7.0.0.

Relates elastic/elasticsearch#36130
Relates elastic/elasticsearch#35958

Fixes #10528
elasticsearch-bot pushed a commit to elastic/logstash that referenced this pull request Mar 12, 2019
This commit changes /_xpack/monitoring/_bulk to /_monitoring/bulk.
The former is deprecrated as 7.0.0.

Relates elastic/elasticsearch#36130
Relates elastic/elasticsearch#35958

Fixes #10528
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants