Skip to content

SQL: Make INTERVAL millis optional #36043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2018
Merged

SQL: Make INTERVAL millis optional #36043

merged 1 commit into from
Nov 29, 2018
+64 −14

Conversation

@costin
Copy link
Member

@costin costin commented Nov 29, 2018

Fractions of the second are not mandatory anymore inside INTERVAL
declarations

Fix #36032

@costin
SQL: Make INTERVAL millis optional
5fb78cf 
Fractions of the second are not mandatory anymore inside INTERVAL
 declarations

Fix elastic#36032
@costin costin requested review from astefan, bpintea and matriv November 29, 2018 11:56
@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 29, 2018

Pinging @elastic/es-search

bpintea
bpintea approved these changes Nov 29, 2018
View reviewed changes
Copy link
Contributor

@bpintea bpintea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@costin costin merged commit 1d458e3 into elastic:master Nov 29, 2018
@costin costin deleted the fix-36032 branch November 29, 2018 16:52
costin added a commit that referenced this pull request Nov 29, 2018
@costin
SQL: Make INTERVAL millis optional (#36043)
eaa2c3e 
Fractions of the second are not mandatory anymore inside INTERVAL
 declarations

Fix #36032

(cherry picked from commit 1d458e3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bpintea bpintea bpintea approved these changes

@astefan astefan Awaiting requested review from astefan

@matriv matriv Awaiting requested review from matriv

Assignees

No one assigned

Labels

:Analytics/SQL SQL querying >enhancement v6.6.0 v7.0.0-beta1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@costin @elasticmachine @bpintea @colings86