Remove X-Pack centric graph endpoints #36010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is part of our plan to deprecate and ultimately remove the use of _xpack in the REST APIs.
jasontedor
added
:Search/Search
|
Pinging @elastic/es-search |
11 tasks
markharwood
reviewed
Nov 28, 2018
| "path": "/{index}/_xpack/graph/_explore", | ||
| "paths": ["/{index}/_xpack/graph/_explore", "/{index}/{type}/_xpack/graph/_explore"], | ||
| "path": "/{index}/_xpack/_graph/explore", | ||
| "paths": ["/{index}/_xpack/_graph/explore", "/{index}/{type}/_xpack/_graph/explore"], | ||
| "parts" : { |
There was a problem hiding this comment.
@markharwood Oops, thanks! I pushed a2dc134.
|
Do the yaml tests now need a "skip" marker for <7.0 versions now that we changed the endpoint? Presumably the BWC tests would fail if a 7.x client sends to a 6.x cluster? |
|
@markharwood Yeah, I pushed 8118f03. |
|
LGTM. Kibana Graph UI has a small label in the "last request" spy that shows the URL used for the graph call - I can change that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is part of our plan to deprecate and ultimately remove the use of _xpack in the REST APIs.
Relates #35958