Skip to content

Conversation

@jtibshirani
Copy link
Contributor

@jtibshirani jtibshirani commented Nov 27, 2018

For each API, the following updates were made:

  • Add deprecation warnings to Rest*Action, plus tests in Rest*ActionTests.
  • For each REST yml test, make sure there is one version without types, and another legacy version that retains types (called *_with_types.yml).
  • Deprecate relevant methods on the Java HLRC requests/ responses.
  • Update documentation (for both the REST API and Java HLRC).

@jtibshirani jtibshirani changed the title Deprecate types in get, exists, and mget requests. Deprecate types in get, exists, and multi get. Nov 27, 2018
@jpountz
Copy link
Contributor

jpountz commented Nov 27, 2018

Can you add a description to the pull request here as well?

@jtibshirani jtibshirani added :Search Foundations/Mapping Index mappings, including merging and defining field types >deprecation labels Nov 27, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

@jtibshirani jtibshirani added v7.0.0 and removed WIP labels Nov 27, 2018
@jtibshirani jtibshirani force-pushed the deprecate-types-in-get branch 3 times, most recently from 4131028 to 1150754 Compare December 10, 2018 22:08
@jtibshirani jtibshirani force-pushed the deprecate-types-in-get branch from 1150754 to 537763e Compare December 10, 2018 23:43
@jtibshirani
Copy link
Contributor Author

I force-pushed because this PR was getting a bit messy, but it contains the same changes from when it was first reviewed, plus several fixes in integration tests to replace custom types with _doc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>deprecation :Search Foundations/Mapping Index mappings, including merging and defining field types v7.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants