[CCR] Rename leaderClient variables and parameters to remoteClient #35368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
added
>non-issue
:Distributed Indexing/CCR
Collaborator
|
Pinging @elastic/es-distributed |
jasontedor
approved these changes
Nov 8, 2018
Member
jasontedor
left a comment
jasontedor
left a comment
There was a problem hiding this comment.
LGTM. I left one change, no need for another round.
|
|
||
| final Client leaderClient = client.getRemoteClusterClient(clusterAlias); | ||
| hasPrivilegesToFollowIndices(leaderClient, new String[] {leaderIndex}, e -> { | ||
| final Client remoteCluster = client.getRemoteClusterClient(clusterAlias); |
Member
There was a problem hiding this comment.
This one I think should be remoteClient?
martijnvg
added a commit
that referenced
this pull request
Nov 8, 2018
martijnvg
added a commit
that referenced
this pull request
Nov 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.