Skip to content

Conversation

@lipsill
Copy link
Contributor

@lipsill lipsill commented Oct 30, 2018

Removes _source_include and _source_exclude url parameters.
These parameters have been deprecated in #33475.

Closes #22792

@nik9000 nik9000 added :Search/Search Search-related issues that do not fall into other categories v7.0.0 labels Oct 30, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@nik9000
Copy link
Member

nik9000 commented Oct 30, 2018

@nik9000
Copy link
Member

nik9000 commented Oct 30, 2018

Otherwise this looks good to me. Thanks @lipsill!

@nik9000
Copy link
Member

nik9000 commented Oct 30, 2018

@elasticmachine, test this please

@lipsill
Copy link
Contributor Author

lipsill commented Oct 31, 2018

@nik9000 thanks for the hint! Note added.

Should I also add a note to 6.x migration docs for the deprecation?

@nik9000
Copy link
Member

nik9000 commented Oct 31, 2018

Should I also add a note to 6.x migration docs for the deprecation?

I did it when I made the backport. That is just one of the extra parts of doing a backport for us.

@nik9000
Copy link
Member

nik9000 commented Oct 31, 2018

@elasticmachine, test this please.

@nik9000 nik9000 merged commit d181d1b into elastic:master Oct 31, 2018
@nik9000
Copy link
Member

nik9000 commented Oct 31, 2018

I've merged this to master. Thanks @lipsill!

javanna pushed a commit that referenced this pull request May 20, 2019
…ec (#42188)

Support for these parameters was removed in #35097. The spec were left outdated.
javanna pushed a commit that referenced this pull request May 20, 2019
…ec (#42188)

Support for these parameters was removed in #35097. The spec were left outdated.
javanna pushed a commit that referenced this pull request May 20, 2019
…ec (#42188)

Support for these parameters was removed in #35097. The spec were left outdated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>breaking :Search/Search Search-related issues that do not fall into other categories v7.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants