throw exception when ilm-rollover-step runs on index without rollover alias #35065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… alias The ILM Rollover Step can execute on the incorrect index if the rollover alias exists on another valid index, but not the one the step is executing against. This is a problem and is now guarded against
talevy
added
>bug
:Data Management/ILM+SLM
Collaborator
|
Pinging @elastic/es-core-infra |
Contributor
Author
|
let me know if you think there should be integration tests for the same unit test. I chose to leave it out since the unit test should cover the same |
gwbrown
approved these changes
Oct 29, 2018
Contributor
gwbrown
left a comment
gwbrown
left a comment
There was a problem hiding this comment.
LGTM assuming CI passes - I don't see a need for an integration test here.
Contributor
Author
|
run sample packaging tests |
dakrone
approved these changes
Oct 30, 2018
colings86
approved these changes
Oct 30, 2018
talevy
added a commit
that referenced
this pull request
Oct 30, 2018
… alias (#35065) The ILM Rollover Step can execute on the incorrect index if the rollover alias exists on another valid index, but not the one the step is executing against. This is a problem and is now guarded against
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ILM Rollover Step can execute on the incorrect index if the rollover alias
exists on another valid index, but not the one the step is executing against. This
is a problem and is now guarded against