Fix logging of cluster state update descriptions#34182
Merged
DaveCTurner merged 2 commits intoelastic:masterfrom Oct 2, 2018
Merged
Fix logging of cluster state update descriptions#34182DaveCTurner merged 2 commits intoelastic:masterfrom
DaveCTurner merged 2 commits intoelastic:masterfrom
Conversation
In elastic#28941 we changed the computation of cluster state task descriptions but this introduced a bug in which we only log the empty descriptions (rather than the non-empty ones). This PR fixes that.
DaveCTurner
added
>bug
v7.0.0
:Distributed/Cluster Coordination
Collaborator
|
Pinging @elastic/es-distributed |
Contributor
Author
|
#28941 was justified by a microbenchmark that showed that this implementation was very significantly faster than the one that it replaces. Re-running this benchmark with this fix shows the improvement remains very significant. |
Contributor
Author
|
@elasticmachine test this please |
DaveCTurner
added a commit
that referenced
this pull request
Oct 2, 2018
In #28941 we changed the computation of cluster state task descriptions but this introduced a bug in which we only log the empty descriptions (rather than the non-empty ones). This change fixes that.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Oct 2, 2018
In elastic#28941 we changed the computation of cluster state task descriptions but this introduced a bug in which we only log the empty descriptions (rather than the non-empty ones). This change fixes that. Backport of elastic#34182.
DaveCTurner
added a commit
that referenced
this pull request
Oct 2, 2018
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
In #28941 we changed the computation of cluster state task descriptions but this introduced a bug in which we only log the empty descriptions (rather than the non-empty ones). This change fixes that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #28941 we changed the computation of cluster state task descriptions but
this introduced a bug in which we only log the empty descriptions (rather than
the non-empty ones). This PR fixes that bug.