Skip to content

Conversation

@nik9000
Copy link
Member

@nik9000 nik9000 commented Sep 25, 2018

This drops two deprecated methods from ESLoggerFactory, switching all
calls to those methods to calls to methods of the same name on
LogManager.

This drops two deprecated methods from `ESLoggerFactory`, switching all
calls to those methods to calls to methods of the same name on
`LogManager`.
@nik9000 nik9000 added :Core/Infra/Logging Log management and logging utilities v7.0.0 >refactoring v6.5.0 labels Sep 25, 2018
@nik9000 nik9000 requested a review from rjernst September 25, 2018 16:00
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@nik9000 nik9000 merged commit ddce970 into elastic:master Sep 26, 2018
nik9000 added a commit that referenced this pull request Sep 26, 2018
This drops two deprecated methods from `ESLoggerFactory`, switching all
calls to those methods to calls to methods of the same name on
`LogManager`.
kcm pushed a commit that referenced this pull request Oct 30, 2018
This drops two deprecated methods from `ESLoggerFactory`, switching all
calls to those methods to calls to methods of the same name on
`LogManager`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants