[TESTS] Pin MockWebServer to TLS1.2 #33127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that the SSLConfigurationReloaderTests can run with JDK 11 by pinning the Server TLS version to TLS1.2 Resolves elastic#32124
jkakavas
added
>test
Collaborator
|
Pinging @elastic/es-security |
jkakavas
added a commit
to jkakavas/elasticsearch
that referenced
this pull request
Sep 14, 2018
Ensure that the SSLConfigurationReloaderTests can run with JDK 11 by pinning the HttpClient to TLS version to TLS1.2. This is necessary becase even if the MockWebServer is set to user TLS1.2, we don't set its enabled protocols, so if it receives a TLS1.3 request (which is the default behavior for HttpClient in JDK11), it will use TLS1.3 and the original issue will manifest again. Relates elastic#33127 Resolves elastic#32124
jkakavas
added a commit
that referenced
this pull request
Sep 14, 2018
Ensure that the SSLConfigurationReloaderTests can run with JDK 11 by pinning the HttpClient to TLS version to TLS1.2. This is necessary becase even if the MockWebServer is set to user TLS1.2, we don't set its enabled protocols, so if it receives a TLS1.3 request (which is the default behavior for HttpClient in JDK11), it will use TLS1.3 and the original issue will manifest again. Relates #33127 Resolves #32124
jaymode
added a commit
to jaymode/elasticsearch
that referenced
this pull request
Sep 28, 2018
Revert "[TESTS] Pin MockWebServer to TLS1.2 (elastic#33127)" (commit 214652d) and "Pin TLS1.2 in SSLConfigurationReloaderTests" (commit d9f5e4f), which pinned the MockWebServer used in the SSLConfigurationReloaderTests to TLSv1.2 in order to prevent failures with JDK 11 related to ssl session invalidation. We no longer need this pinning as the problematic code was fixed in elastic#34130.
jaymode
added a commit
that referenced
this pull request
Oct 2, 2018
Revert "[TESTS] Pin MockWebServer to TLS1.2 (#33127)" (commit 214652d) and "Pin TLS1.2 in SSLConfigurationReloaderTests" (commit d9f5e4f), which pinned the MockWebServer used in the SSLConfigurationReloaderTests to TLSv1.2 in order to prevent failures with JDK 11 related to ssl session invalidation. We no longer need this pinning as the problematic code was fixed in #34130.
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
Revert "[TESTS] Pin MockWebServer to TLS1.2 (#33127)" (commit 214652d) and "Pin TLS1.2 in SSLConfigurationReloaderTests" (commit d9f5e4f), which pinned the MockWebServer used in the SSLConfigurationReloaderTests to TLSv1.2 in order to prevent failures with JDK 11 related to ssl session invalidation. We no longer need this pinning as the problematic code was fixed in #34130.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the SSLConfigurationReloaderTests can run with JDK 11
by pinning the Server TLS version to TLS1.2
Resolves #32124