Tests: Fix Typo Causing Flaky Settings Test #32665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* We were comparing the wrong timeout value in the `randomValueOtherThan` call here, leading to no mutation happening for a certain seed * closes #32639
original-brownbear
added
:Core/Infra/Settings
Collaborator
|
Pinging @elastic/es-core-infra |
colings86
approved these changes
Aug 7, 2018
Contributor
colings86
left a comment
colings86
left a comment
There was a problem hiding this comment.
LGTM, thanks for catching this @original-brownbear
Contributor
Author
|
@colings86 thanks for the review! Will merge once green :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
randomValueOtherThancall here, leading to no mutation happening for a certain seed