Skip to content

[ML] Switch ML native QA tests to use a 3 node cluster #31757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2018
Merged

[ML] Switch ML native QA tests to use a 3 node cluster #31757

merged 1 commit into from
Jul 10, 2018

Conversation

@davidkyle
Copy link
Member

@davidkyle davidkyle commented Jul 3, 2018

Single node tests are not representative of how ML is used in the real world and the bug #31691 would have been discovered early if in a multi node test. This changes the ml-native-tests project to run in a 3 node cluster

This change is essentially renaming the ml-native-tests project to ml-native-multi-node-tests and setting numNodes = 3

The gradle command to run the tests is ./gradlew :x-pack:qa:ml-native-multi-node-tests:integTest

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 3, 2018

Pinging @elastic/ml-core

dimitris-athanasiou
dimitris-athanasiou approved these changes Jul 3, 2018
View reviewed changes
Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl lcawl added the >test Issues or PRs that are addressing/adding tests label Jul 3, 2018
@davidkyle davidkyle added v6.3.2 and removed v6.3.1 labels Jul 5, 2018
@dimitris-athanasiou dimitris-athanasiou mentioned this pull request Jul 6, 2018
Merged
dimitris-athanasiou added a commit that referenced this pull request Jul 7, 2018
@dimitris-athanasiou
[ML] Fix master node deadlock during ML daily maintenance (#31836)
49ba271 
This is the implementation for master and 6.x of #31691.
Native tests are changed to use multi-node clusters in #31757.

Relates #31683
dimitris-athanasiou added a commit that referenced this pull request Jul 7, 2018
@dimitris-athanasiou
[ML] Fix master node deadlock during ML daily maintenance (#31836)
3c01f1c 
This is the implementation for master and 6.x of #31691.
Native tests are changed to use multi-node clusters in #31757.

Relates #31683
@dimitris-athanasiou
Copy link
Contributor

dimitris-athanasiou commented Jul 7, 2018

@davidkyle As #31836 is now merged, rebasing this should result in passing tests.

@davidkyle davidkyle merged commit 991d17c into elastic:master Jul 10, 2018
@davidkyle davidkyle deleted the multi-node-tests branch July 10, 2018 07:26
@davidkyle davidkyle mentioned this pull request Jul 11, 2018
Merged
davidkyle added a commit to davidkyle/elasticsearch that referenced this pull request Jul 12, 2018
@davidkyle
[ML] Switch native QA tests to a 3 node cluster (elastic#31757)
e6e205f
@davidkyle davidkyle mentioned this pull request Jul 12, 2018
Merged
dnhatn added a commit that referenced this pull request Jul 12, 2018
@dnhatn
Merge branch 'master' into ccr
b1f5d36 
* master:
  [TEST] Mute SlackMessageTests.testTemplateRender
  Docs: Explain closing the high level client
  [ML] Re-enable memory limit integration tests (#31328)
  [test] disable packaging tests for suse boxes
  Add nio transport to security plugin (#31942)
  XContentTests : Insert random fields at random positions (#30867)
  Force execution of fetch tasks (#31974)
  Fix unreachable error condition in AmazonS3Fixture (#32005)
  Tests: Fix SearchFieldsIT.testDocValueFields (#31995)
  Add Expected Reciprocal Rank metric (#31891)
  [ML] Get ForecastRequestStats doc in RestoreModelSnapshotIT (#31973)
  SQL: Add support for single parameter text manipulating functions (#31874)
  [ML] Ensure immutability of MlMetadata (#31957)
  Tests: Mute SearchFieldsIT.testDocValueFields()
  muted tests due to #31940
  Work around reported problem in eclipse (#31960)
  Move build integration tests out of :buildSrc project (#31961)
  Tests: Remove use of joda time in some tests (#31922)
  [Test] Reactive 3rd party tests on CI (#31919)
  SQL: Support for escape sequences (#31884)
  SQL: HAVING clause should accept only aggregates (#31872)
  Docs: fix typo in datehistogram (#31972)
  Switch url repository rest tests to new style requests (#31944)
  Switch reindex tests to new style requests (#31941)
  Docs: Added note about cloud service to installation and getting started
  [DOCS] Removes alternative docker pull example (#31934)
  Add Snapshots Status API to High Level Rest Client (#31515)
  ingest: date_index_name processor template resolution (#31841)
  Test: fix null failure in watcher test (#31968)
  Switch test framework to new style requests (#31939)
  Switch low level rest tests to new style Requests (#31938)
  Switch high level rest tests to new style requests (#31937)
  [ML] Mute test failing due to Java 11 date time format parsing bug (#31899)
  [TEST] Mute SlackMessageTests.testTemplateRender
  Fix assertIngestDocument wrongfully passing (#31913)
  Remove unused reference to filePermissionsCache (#31923)
  rolling upgrade should use a replica to prevent relocations while running a scroll
  HLREST: Bundle the x-pack protocol project (#31904)
  Increase logging level for testStressMaybeFlush
  Added lenient flag for synonym token filter (#31484)
  [X-Pack] Beats centralized management: security role + licensing (#30520)
  HLRest: Move xPackInfo() to xPack().info() (#31905)
  Docs: add security delete role to api call table (#31907)
  [test] port archive distribution packaging tests (#31314)
  Watcher: Slack message empty text (#31596)
  [ML] Mute failing DetectionRulesIT.testCondition() test
  Fix broken NaN check in MovingFunctions#stdDev() (#31888)
  Date: Add DateFormatters class that uses java.time (#31856)
  [ML] Switch native QA tests to a 3 node cluster (#31757)
  Change trappy float comparison (#31889)
  Fix building AD URL from domain name (#31849)
  Add opaque_id to audit logging (#31878)
  re-enable backcompat tests
  add support for is_write_index in put-alias body parsing (#31674)
  Improve release notes script (#31833)
  [DOCS] Fix broken link in painless example
  Handle missing values in painless (#30975)
  Remove the ability to index or query context suggestions without context (#31007)
  Ingest: Enable Templated Fieldnames in Rename (#31690)
  [Docs] Fix typo in the Rollup API Quick Reference (#31855)
  Ingest: Add ignore_missing option to RemoveProc (#31693)
  Add template config for Beat state to X-Pack Monitoring (#31809)
  Watcher: Add ssl.trust email account setting (#31684)
  Remove link to oss-MSI (#31844)
  Painless: Restructure Definition/Whitelist (#31879)
  HLREST: Add x-pack-info API (#31870)
@davidkyle davidkyle mentioned this pull request Jul 18, 2018
Merged
droberts195 pushed a commit to droberts195/elasticsearch that referenced this pull request Oct 17, 2018
[TEST] Reduce forecast disk space requirement for tests
021699c 
The setting that reduces the disk space requirement
for the forecasting integration tests was accidentally
removed in elastic#31757 when files were moved around.  This
change simply adds back the setting that existed before
that.
@droberts195 droberts195 mentioned this pull request Oct 17, 2018
Merged
droberts195 pushed a commit that referenced this pull request Oct 18, 2018
[TEST] Reduce forecast disk space requirement for tests (#34552)
0f8d05f 
The setting that reduces the disk space requirement
for the forecasting integration tests was accidentally
removed in #31757 when files were moved around.  This
change simply adds back the setting that existed before
that.
droberts195 pushed a commit that referenced this pull request Oct 18, 2018
[TEST] Reduce forecast disk space requirement for tests (#34552)
1ff55f4 
The setting that reduces the disk space requirement
for the forecasting integration tests was accidentally
removed in #31757 when files were moved around.  This
change simply adds back the setting that existed before
that.
droberts195 pushed a commit that referenced this pull request Oct 18, 2018
[TEST] Reduce forecast disk space requirement for tests (#34552)
e7b8664 
The setting that reduces the disk space requirement
for the forecasting integration tests was accidentally
removed in #31757 when files were moved around.  This
change simply adds back the setting that existed before
that.
matriv pushed a commit to matriv/elasticsearch that referenced this pull request Oct 19, 2018
@matriv
[TEST] Reduce forecast disk space requirement for tests (elastic#34552)
548bbd8 
The setting that reduces the disk space requirement
for the forecasting integration tests was accidentally
removed in elastic#31757 when files were moved around.  This
change simply adds back the setting that existed before
that.
kcm pushed a commit that referenced this pull request Oct 30, 2018
@kcm
[TEST] Reduce forecast disk space requirement for tests (#34552)
a3b5a97 
The setting that reduces the disk space requirement
for the forecasting integration tests was accidentally
removed in #31757 when files were moved around.  This
change simply adds back the setting that existed before
that.
@colings86 colings86 removed the v7.0.0 label Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dimitris-athanasiou dimitris-athanasiou dimitris-athanasiou approved these changes

Assignees

No one assigned

Labels

:ml Machine learning >test Issues or PRs that are addressing/adding tests v6.3.2 v6.4.0 v7.0.0-beta1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@davidkyle @elasticmachine @dimitris-athanasiou @colings86 @lcawl