-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Update analysis.asciidoc #31586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update analysis.asciidoc #31586
Conversation
|
Thank you for your PR @edjw! Can you please sign the contributor license agreement so we can merge your change? |
|
Pinging @elastic/es-search-aggs |
cbuescher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good, just waiting for CLA before merging. Thanks @edjw for spotting this.
cbuescher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edjw sorry, actually, I have to correct myself. "lazi" is a stemmed version of "lazy", so the output is correct like it currently is. You can check this using:
POST _analyze
{
"analyzer": "english",
"text": ["The QUICK brown foxes jumped over the lazy dog!"]
}
I think this doesn't need correction in the docs, so I hope you don't mind if we close this.
Alternatively I think you could add a very short note below the example explaining why this is "lazi" not "lazy", because I agree this looks like a typo at first glance. |
|
Think it makes sense to close and explain why it is the way it is. (By the way, I went to sign the contributor license agreement twice and couldn't because I block third party cookies. And if I'm honest, I wasn't motivated enough to go in and make an exception for these domains just for a typo PR. Just a bit of feedback on the CLA stuff. I'm sure you have your reasons for asking people to sign the agreement but it was a bit more friction in the process than I'm used to.) |
|
@edjw no problem, I can understand you don't want to sign the CLA just for a tiny change like this.
Yes, we require a CLA also just for documentation changes. I'd be curious to learn what the process looks like for other open source projects (maybe with a commercial entity in the back) when there is less perceived friction. Do you have any examples? Thanks for pointing this out anyway, I will close the issue. |
gradle check?