Skip to content

Conversation

@edjw
Copy link

@edjw edjw commented Jun 26, 2018

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS that we support?
  • If you are submitting this code for a class then read our policy for that.

@danielmitterdorfer
Copy link
Member

Thank you for your PR @edjw! Can you please sign the contributor license agreement so we can merge your change?

@danielmitterdorfer danielmitterdorfer added >enhancement >docs General docs changes labels Jun 27, 2018
@colings86 colings86 added the :Search Relevance/Analysis How text is split into tokens label Jun 27, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, just waiting for CLA before merging. Thanks @edjw for spotting this.

@cbuescher cbuescher self-assigned this Jun 27, 2018
Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edjw sorry, actually, I have to correct myself. "lazi" is a stemmed version of "lazy", so the output is correct like it currently is. You can check this using:

POST _analyze
{
  "analyzer": "english", 
  "text": ["The QUICK brown foxes jumped over the lazy dog!"]
}

I think this doesn't need correction in the docs, so I hope you don't mind if we close this.

@cbuescher
Copy link
Member

I hope you don't mind if we close this

Alternatively I think you could add a very short note below the example explaining why this is "lazi" not "lazy", because I agree this looks like a typo at first glance.

@edjw
Copy link
Author

edjw commented Jun 27, 2018

Think it makes sense to close and explain why it is the way it is.

(By the way, I went to sign the contributor license agreement twice and couldn't because I block third party cookies. And if I'm honest, I wasn't motivated enough to go in and make an exception for these domains just for a typo PR. Just a bit of feedback on the CLA stuff. I'm sure you have your reasons for asking people to sign the agreement but it was a bit more friction in the process than I'm used to.)

@cbuescher
Copy link
Member

@edjw no problem, I can understand you don't want to sign the CLA just for a tiny change like this.

I'm sure you have your reasons for asking people to sign the agreement but it was a bit more friction in the process than I'm used to.)

Yes, we require a CLA also just for documentation changes. I'd be curious to learn what the process looks like for other open source projects (maybe with a commercial entity in the back) when there is less perceived friction. Do you have any examples?

Thanks for pointing this out anyway, I will close the issue.

@cbuescher cbuescher closed this Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>docs General docs changes >enhancement :Search Relevance/Analysis How text is split into tokens

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants