Skip to content

Add a helper method to get a random java.util.TimeZone #29487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dakrone merged 2 commits into from
Apr 12, 2018
Merged

Add a helper method to get a random java.util.TimeZone #29487

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0306886
Add a helper method to get a random java.util.TimeZone
dakrone Apr 11, 2018
00a418b
Switch to a statically initialized and sorted set of TZ ids
dakrone Apr 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions test/framework/src/main/java/org/elasticsearch/test/ESTestCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@
import java.util.Objects;
import java.util.Random;
import java.util.Set;
import java.util.TimeZone;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicInteger;
Expand Down Expand Up @@ -674,6 +675,15 @@ public static DateTimeZone randomDateTimeZone() {
return DateTimeZone.forID(randomFrom(ids));
}

/**
* generate a random TimeZone from the ones available in java.time
*/
public static TimeZone randomTimeZone() {
List<String> ids = Arrays.asList(TimeZone.getAvailableIDs());
Copy link
Member

@rjernst rjernst Apr 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could these be statically loaded so calls to this do not each need to do a sort?

Copy link
Member

@cbuescher cbuescher Apr 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just looking at how we currently do this for the joda DateTimeZone in randomDateTimeZone, I think that method would benefit slighty as well from making the sorted IDs static. Would make sense to maybe change this in one go?

Copy link
Member Author

@dakrone dakrone Apr 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I switched them both to use statically initialized and sorted lists

Collections.sort(ids);
return TimeZone.getTimeZone(randomFrom(ids));
}

/**
* helper to randomly perform on <code>consumer</code> with <code>value</code>
*/
Expand Down