Skip to content

Conversation

@DaveCTurner
Copy link
Contributor

The settings indices.recovery.concurrent_streams and
indices.recovery.concurrent_small_file_streams were removed in
f5e4cd4. This commit removes their last traces
from the codebase.

Relates #28781

Pinging @elastic/es-core-infra

The settings `indices.recovery.concurrent_streams` and
`indices.recovery.concurrent_small_file_streams` were removed in
f5e4cd4. This commit removes their last traces
from the codebase.

Relates elastic#28781
@DaveCTurner DaveCTurner added >non-issue >test Issues or PRs that are addressing/adding tests :Core/Infra/Settings Settings infrastructure and APIs labels Mar 15, 2018
@DaveCTurner DaveCTurner requested a review from s1monw March 15, 2018 12:28
}


public void testHandleExceptinoOnSendSendFiles() throws Throwable {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Exceptino/Exception/ while you are here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a worthwhile correctino. Pushed pushed f4759cd, fixing the send send files too.

@DaveCTurner DaveCTurner removed the request for review from s1monw March 15, 2018 13:51
@nik9000
Copy link
Member

nik9000 commented Mar 15, 2018

I didn't even see the SendSend part.

❤️

@DaveCTurner DaveCTurner merged commit 158bb23 into elastic:master Mar 16, 2018
DaveCTurner added a commit that referenced this pull request Mar 16, 2018
The settings `indices.recovery.concurrent_streams` and
`indices.recovery.concurrent_small_file_streams` were removed in
f5e4cd4. This commit removes their last traces
from the codebase.
@DaveCTurner DaveCTurner deleted the 2018-03-15-remove-obsolete-settings branch July 23, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Core/Infra/Settings Settings infrastructure and APIs >non-issue >test Issues or PRs that are addressing/adding tests v6.3.0 v7.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants