[Docs] Docs tests should wait for async execution to complete #28481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit splits the async execution documentation into 2 parts, one for the async method itself and one for the action listener. This allows to add more doc and to use CountDownLatches in doc tests to wait for asynchronous operations to be completed before moving to the next test. It also renames few files. Related to elastic#28457
tlrx
commented
Feb 1, 2018
| [[java-rest-high-document-index-async]] | ||
| ==== Asynchronous Execution | ||
|
|
||
| The asynchronous execution of an index request requires both the `IndexRequest` |
Member
Author
There was a problem hiding this comment.
Note: I used the same wording in all docs, so feel free to only comment once. I'll apply any potential changes by grepping and sedding all the files together.
javanna
reviewed
Feb 1, 2018
| include::close_index.asciidoc[] | ||
|
|
||
| include::putmapping.asciidoc[] | ||
| include::put_mapping.asciidoc[] |
Member
There was a problem hiding this comment.
thanks, I had this rename coming too.
javanna
approved these changes
Feb 1, 2018
tlrx
added a commit
that referenced
this pull request
Feb 2, 2018
This commit splits the async execution documentation into 2 parts, one for the async method itself and one for the action listener. This allows to add more doc and to use CountDownLatches in doc tests to wait for asynchronous operations to be completed before moving to the next test. It also renames few files. Related to #28457
tlrx
added a commit
that referenced
this pull request
Feb 21, 2018
This commit splits the async execution documentation into 2 parts, one for the async method itself and one for the action listener. This allows to add more doc and to use CountDownLatches in doc tests to wait for asynchronous operations to be completed before moving to the next test. It also renames few files. Related to #28457
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit splits the async execution documentation into 2 parts, one
for the async method itself and one for the action listener. This allows
to add more doc and to use CountDownLatches in doc tests to wait for
asynchronous operations to be completed before moving to the next test.
It also renames few files.
Related to #28457 (comment)