Add deprecation message for config prompt #28000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not sure how to label something for deprecation... I also need some guidance on where the docs live so i can update those as well. github search failed me, but simple grep showed me the way... I found the docs |
jasontedor
reviewed
Jan 2, 2018
There was a problem hiding this comment.
I think this is a little misleading. Today prompting can be used on any setting, but not every setting is eligible for secure settings.
There was a problem hiding this comment.
Oh i was not aware of this! ty for this info. im also bumping this to 6.3
hub-cap
force-pushed
the
deprecation_config_prompt_6.x
branch
from
2ff77f7 to
0a4292d
Compare
|
Ive updated the PR to note that not all settings can be secure settings in the prompt'ing and docs. |
rjernst
approved these changes
Jan 23, 2018
| } | ||
|
|
||
| terminal.println(Terminal.Verbosity.SILENT, | ||
| "Prompting for property values is deprecated in " + Version.CURRENT |
There was a problem hiding this comment.
Should this be hardcoded and reworded to "since X.Y.Z"?
| === Prompting for settings | ||
|
|
||
| NOTE: Prompting for settings is deprecated. Please use <<secure-settings>> | ||
| for sensitive property values. Not all properties can be converted to use |
| } | ||
|
|
||
| terminal.println(Terminal.Verbosity.SILENT, | ||
| "Prompting for property values is deprecated in " + Version.CURRENT |
jasontedor
approved these changes
Jan 24, 2018
jpountz
added
:Core/Infra/Core
|
Pinging @elastic/es-core-infra |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates #27216