Remove workaround in translog rest test #27530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
>test
Contributor
|
LGTM. Heads up - I think the multiple commit point work we're working on will also cause trouble in this test. |
bleskes
approved these changes
Nov 27, 2017
Member
Author
|
Thanks @bleskes. |
jasontedor
added a commit
that referenced
this pull request
Nov 27, 2017
* master: Skip shard refreshes if shard is `search idle` (#27500) Remove workaround in translog rest test (#27530) inner_hits: Return an empty _source for nested inner hit when filtering on a field that doesn't exist. percolator: Avoid TooManyClauses exception if number of terms / ranges is exactly equal to 1024 Dedup translog operations by reading in reverse (#27268) Ensure logging is configured for CLI commands Ensure `doc_stats` are changing even if refresh is disabled (#27505) Fix classes that can exit Revert "Adjust CombinedDeletionPolicy for multiple commits (#27456)" Transpose expected and actual, and remove duplicate info from message. (#27515) [DOCS] Fixed broken link in breaking changes
dnhatn
added a commit
that referenced
this pull request
Mar 31, 2018
dnhatn
added a commit
that referenced
this pull request
Mar 31, 2018
dnhatn
added a commit
that referenced
this pull request
Mar 31, 2018
Even though the option wait_for_no_initializing_shards is backported to 6.2, we should not remove this workaround on 6.2 because this rest test will be run in a mixed cluster in which the wait_for_no_initializing_shards may not be available. This reverts commit 7aea8b5.
dnhatn
added a commit
that referenced
this pull request
Mar 31, 2018
Even though the option wait_for_no_initializing_shards is backported to 6.2, we should not remove this workaround on 6.3 because this rest test will be run in a mixed cluster in which the wait_for_no_initializing_shards may not be available. This reverts commit 7aea8b5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a workaround in a translog rest test using
wait_for_initializing_shards.Relates #25623 and a6db0ea