Skip to content

Conversation

@dnhatn
Copy link
Member

@dnhatn dnhatn commented Nov 17, 2017

We introduced a new snapshot status update handler in 6.1.0. We will keep the old handler along with this new one in all 6.x. This commit removes the old handler from 7.0.

Relates #27151

We introduced a new snapshot status update handler in 6.1.0. We will
keep the old handler along with the new one in all 6.x but remove it in
7.0.

Relates elastic#27151
@dnhatn dnhatn added :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >non-issue labels Nov 17, 2017
@jasontedor jasontedor removed their request for review November 17, 2017 21:01
Copy link
Contributor

@imotov imotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this should go in at the same time with backport of #27151 to 6.x and fixes to x-pack. Please also note that in backport we should change version in onOrAfter(Version.V_7_0_0_alpha1)).

@dnhatn dnhatn merged commit 4f711a8 into elastic:master Nov 18, 2017
@dnhatn dnhatn deleted the remove-snapshot-old-handler branch November 18, 2017 01:14
@dnhatn
Copy link
Member Author

dnhatn commented Nov 18, 2017

Thanks @imotov for the review.

@dnhatn dnhatn added the v7.0.0 label Nov 18, 2017
jasontedor added a commit that referenced this pull request Nov 20, 2017
* master: (31 commits)
  [TEST] Fix `GeoShapeQueryTests#testPointsOnly` failure
  Transition transport apis to use void listeners (#27440)
  AwaitsFix GeoShapeQueryTests#testPointsOnly #27454
  Bump test version after backport
  Ensure nested documents have consistent version and seq_ids (#27455)
  Tests: Add Fedora-27 to packaging tests
  Delete some seemingly unused exceptions (#27439)
  #26800: Fix docs rendering
  Remove config prompting for secrets and text (#27216)
  Move the CLI into its own subproject (#27114)
  Correct usage of "an" to "a" in getting started docs
  Avoid NPE when getting build information
  Removes BWC snapshot status handler used in 6.x (#27443)
  Remove manual tracking of registered channels (#27445)
  Remove parameters on HandshakeResponseHandler (#27444)
  [GEO] fix pointsOnly bug for MULTIPOINT
  Standardize underscore requirements in parameters (#27414)
  peanut butter hamburgers
  Log primary-replica resync failures
  Uses TransportMasterNodeAction to update shard snapshot status (#27165)
  ...
@jimczi jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >non-issue v7.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants