-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Docs/windows installer #27369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs/windows installer #27369
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Left a small comment around INSTALLDIR
| The **exception** to this is `INSTALLDIR` (if originally specified), which must be a different directory to the | ||
| current installation. | ||
| If setting `INSTALLDIR`, we recommend that the final directory in the path be the version of Elasticsearch e.g. | ||
| ++C:\Program Files\Elastic\Elasticsearch\{version}++ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not just recommended but currently we have to mandate the installer ends in the version when running the silent install otherwiae the install will fail. THE UI can cope with this though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the installer should only mandate that the directory for the upgrade version is different to the existing version, and not a child directory of the existing version.
|
I updated the description for |
* Add additional command line parameters along with important note for INSTALLDIR when upgrading * Update windows installer images (cherry picked from commit c42899b)
* Add additional command line parameters along with important note for INSTALLDIR when upgrading * Update windows installer images (cherry picked from commit c42899b)
* master: Stop skipping REST test after backport of #27056 Fix default value of ignore_unavailable for snapshot REST API (#27056) Add composite aggregator (#26800) Fix `ShardSplittingQuery` to respect nested documents. (#27398) [Docs] Restore section about multi-level parent/child relation in parent-join (#27392) Add TcpChannel to unify Transport implementations (#27132) Add note on plugin distributions in plugins folder Remove implementations of `TransportChannel` (#27388) Update Google SDK to version 1.23 (#27381) Fix Gradle 4.3.1 compatibility for logging (#27382) [Test] Change Elasticsearch startup timeout to 120s in packaging tests Docs/windows installer (#27369)
Updated documentation for the Windows Installer 6.0 release:
@Mpdreamz would you mind specifically double-checking the instructions with regards to
INSTALLDIRfrom the command line?