Skip to content

Conversation

@JapSeyz
Copy link
Contributor

@JapSeyz JapSeyz commented Aug 11, 2017

A simple fix for a typo

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@JapSeyz
Copy link
Contributor Author

JapSeyz commented Aug 11, 2017

I've signed the CLA, but I hadn't confirmed my email when submitting the PR

@nik9000 nik9000 added the >docs General docs changes label Aug 11, 2017
@nik9000
Copy link
Member

nik9000 commented Aug 11, 2017

Change looks right.

I believe me assigning the label trigger a CLA recheck and it passed. I'll merge this in a few hours if no one else gets to it first.

@nik9000 nik9000 changed the title Fixed typo in attribute name Fixed typo in README.textile Aug 11, 2017
@nik9000 nik9000 merged commit e278eac into elastic:master Aug 11, 2017
nik9000 pushed a commit that referenced this pull request Aug 11, 2017
The attribute name was camelCase in the text but in the example it was snake_case.
nik9000 pushed a commit that referenced this pull request Aug 11, 2017
The attribute name was camelCase in the text but in the example it was snake_case.
nik9000 pushed a commit that referenced this pull request Aug 11, 2017
The attribute name was camelCase in the text but in the example it was snake_case.
nik9000 pushed a commit that referenced this pull request Aug 11, 2017
The attribute name was camelCase in the text but in the example it was snake_case.
@nik9000
Copy link
Member

nik9000 commented Aug 11, 2017

Thanks for squashing the embarrassing typo in the README, @JapSeyz! I've merged to the master branch and backported it to 6.x, 6.0, 5.6, and 5.5 branches.

jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Aug 14, 2017
* master: (30 commits)
  Rewrite range queries with open bounds to exists query (elastic#26160)
  Fix eclipse compilation problem (elastic#26170)
  Epoch millis and second formats parse float implicitly (Closes elastic#14641) (elastic#26119)
  fix SplitProcessor targetField test (elastic#26178)
  Fixed typo in README.textile (elastic#26168)
  Fix incorrect class name in deleteByQuery docs (elastic#26151)
  Move more token filters to analysis-common module
  reindex: automatically choose the number of slices (elastic#26030)
  Fix serialization of the `_all` field. (elastic#26143)
  percolator: Hint what clauses are important in a conjunction query based on fields
  Remove unused Netty-related settings (elastic#26161)
  Remove SimpleQueryStringIT#testPhraseQueryOnFieldWithNoPositions.
  Tests: reenable ShardReduceIT#testIpRange.
  Allow `ClusterState.Custom` to be created on initial cluster states (elastic#26144)
  Teach the build about betas and rcs (elastic#26066)
  Fix wrong header level
  inner hits: Unfiltered nested source should keep its full path
  Document how to import Lucene Snapshot libs when elasticsearch clients (elastic#26113)
  Use `global_ordinals_hash` execution mode when sorting by sub aggregations. (elastic#26014)
  Make the README use a single type in examples. (elastic#26098)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>docs General docs changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants