Add ignore_malformed to geo_shape fields #24654
Merged
+115
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nknize
added
:Analytics/Geo
hudsonb
reviewed
May 13, 2017
cbuescher
approved these changes
Aug 17, 2017
Member
There was a problem hiding this comment.
nit: maybe the field name could be a constant under Names, the same as in e.g. GeoPointFieldMapper (or reuse that one)
Member
There was a problem hiding this comment.
Maybe also use a constant here
Member
There was a problem hiding this comment.
Maybe also check the explicit flag.
Member
|
@nknize can you get this in if still relevant please? |
This commit adds ignore_malformed support to geo_shape field types to skip malformed geoJson fields. closes elastic#23747
jpountz
removed
the
:Search Foundations/Mapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
ignore_malformedsupport togeo_shapefield types to skip malformed geoJson fields. Tests are updated.closes #23747