Skip to content

Conversation

@sudo-suhas
Copy link
Contributor

The keyed parameter is supported by the following aggregations:

However, in the reference guide, the keyed parameter is documented only for Range Aggregation.

Closes #23731.

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@sudo-suhas sudo-suhas changed the title Add reference documentation for aggregations Update aggregations reference documentation for parameter 'keyed' Mar 26, 2017
@sudo-suhas
Copy link
Contributor Author

@javanna Just found that date range aggregation supports keyed as well. Will push another commit to this pull request.

rjernst and others added 4 commits March 27, 2017 14:19
…lastic#23734)

In gradle 3.3 use of getConfiguration on a ModuleDependency was
deprecated. This commit changes it to use getTargetConfiguration.
This change ports the regeneration of antlr parser/lexer into gradle
(but does still take advantage of ant calls where appropriate).
The OpenJDK project provides early-access builds of upcoming
releases. These early-access builds are not suitable for
production. These builds sometimes end up on systems due to aggressive
packaging (e.g., Ubuntu). This commit adds a bootstrap check to ensure
these early-access builds are not being used in production.

Relates elastic#23743
@sudo-suhas
Copy link
Contributor Author

Looks like I screwed up. I rebased using steps explained here - http://stackoverflow.com/questions/7244321/how-do-i-update-a-github-forked-repository. Any idea how to fix this?

@javanna javanna self-assigned this Mar 27, 2017
@javanna
Copy link
Member

javanna commented Mar 27, 2017

@sudo-suhas you can open a new PR. Just create a new branch out of master, add a commit with your changes and push it to your remote repo, then open the PR based on that.

@sudo-suhas
Copy link
Contributor Author

@javanna Thanks. Did just that. Also squashed the commits as recommended in the contributing guide. #23758 . Closing. Also, can I delete this branch?

@sudo-suhas sudo-suhas closed this Mar 27, 2017
@javanna
Copy link
Member

javanna commented Mar 27, 2017

sure you can delete your branch.

@sudo-suhas sudo-suhas deleted the docs_for_keyed branch March 27, 2017 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants