Skip to content

Fix control group pattern#23219

Merged
jasontedor merged 2 commits intoelastic:masterfrom
jasontedor:fix-control-group-pattern
Feb 16, 2017
Merged

Fix control group pattern#23219
jasontedor merged 2 commits intoelastic:masterfrom
jasontedor:fix-control-group-pattern

Conversation

@jasontedor
Copy link
Copy Markdown
Member

The file /proc/self/cgroup lists the control groups to which the process
belongs. This file is a colon separated list of three fields:

  1. a hierarchy ID number
  2. a comma-separated list of hierarchies
  3. the pathname of the control group in the hierarchy

The regex pattern for this contains a bug for the second field. It
allows one or two entries in the comma-separated list, but not
more. This commit fixes the pattern to allow one or more entires in the
comma-separated list.

Closes #23218

The file /proc/self/cgroup lists the control groups to which the process
belongs. This file is a colon separated list of three fields:
 1. a hierarchy ID number
 2. a comma-separated list of hierarchies
 3. the pathname of the control group in the hierarchy

The regex pattern for this contains a bug for the second field. It
allows one or two entries in the comma-separated list, but not
more. This commit fixes the pattern to allow one or more entires in the
comma-separated list.
Copy link
Copy Markdown
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasontedor jasontedor force-pushed the fix-control-group-pattern branch from d52ed47 to de1fb0b Compare February 16, 2017 20:03
@jasontedor jasontedor merged commit 00a8b87 into elastic:master Feb 16, 2017
jasontedor added a commit that referenced this pull request Feb 16, 2017
The file /proc/self/cgroup lists the control groups to which the process
belongs. This file is a colon separated list of three fields:
 1. a hierarchy ID number
 2. a comma-separated list of hierarchies
 3. the pathname of the control group in the hierarchy

The regex pattern for this contains a bug for the second field. It
allows one or two entries in the comma-separated list, but not
more. This commit fixes the pattern to allow one or more entires in the
comma-separated list.

Relates #23219
jasontedor added a commit that referenced this pull request Feb 16, 2017
The file /proc/self/cgroup lists the control groups to which the process
belongs. This file is a colon separated list of three fields:
 1. a hierarchy ID number
 2. a comma-separated list of hierarchies
 3. the pathname of the control group in the hierarchy

The regex pattern for this contains a bug for the second field. It
allows one or two entries in the comma-separated list, but not
more. This commit fixes the pattern to allow one or more entires in the
comma-separated list.

Relates #23219
@jasontedor jasontedor deleted the fix-control-group-pattern branch February 16, 2017 20:33
@jasontedor
Copy link
Copy Markdown
Member Author

Thanks @rjernst.

jasontedor added a commit that referenced this pull request Feb 17, 2017
The file /proc/self/cgroup lists the control groups to which the process
belongs. This file is a colon separated list of three fields:
 1. a hierarchy ID number
 2. a comma-separated list of hierarchies
 3. the pathname of the control group in the hierarchy

The regex pattern for this contains a bug for the second field. It
allows one or two entries in the comma-separated list, but not
more. This commit fixes the pattern to allow one or more entires in the
comma-separated list.

Relates #23219
tylersmalley added a commit to tylersmalley/kibana that referenced this pull request Mar 28, 2017
This was addressed in elastic/elasticsearch#23219

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ES doesn't start due to a problem with REGEX matching of entries in '/proc/self/cgroup'

2 participants