Move EvilPeerRecoveryIT to a unit test in RecoveryDuringReplicationTests #22900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasontedor
approved these changes
Feb 9, 2017
Member
jasontedor
left a comment
jasontedor
left a comment
There was a problem hiding this comment.
LGTM. I'm glad that crazy analyzer is gone. Thanks for doing this @bleskes.
Contributor
Author
|
thx @jasontedor |
nik9000
added a commit
that referenced
this pull request
Feb 9, 2017
Weakens the assertion on wait_for_active_shards so that we don't check the toString of the bulk request because it isn't important. Relates to #22900
nik9000
added a commit
that referenced
this pull request
Feb 9, 2017
Weakens the assertion on wait_for_active_shards so that we don't check the toString of the bulk request because it isn't important. Relates to #22900
nik9000
added a commit
that referenced
this pull request
Feb 9, 2017
Weakens the assertion on wait_for_active_shards so that we don't check the toString of the bulk request because it isn't important. Relates to #22900
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EvillPeerRecoveryIT checks scenario where recovery is happening while there are on going indexing operation that already have been assigned a seq# . This is fairly hard to achieve and the test goes through a couple of hoops via the plugin infra to achieve that. This PR extends the unit tests infra to allow for those hoops to happen in unit tests. This allows the test to be moved to
RecoveryDuringReplicationTestsRelates to #22484