First step towards separating individual search phases #22802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1monw
added
:Search/Search
Contributor
Author
|
@elasticmachine test this please |
jpountz
approved these changes
Jan 26, 2017
Contributor
jpountz
left a comment
jpountz
left a comment
There was a problem hiding this comment.
+1 to detaching phases to make them easier to test/reason about. It is hard to dig into such a change but I got the idea and did not see anything bad, so if tests are passing I'm confident this is good. 👍
At this point AbstractSearchAsyncAction is just a base-class for the first phase of a search where we have multiple replicas for each shardID. If one of them is not available we move to the next one. Yet, once we passed that first stage we have to work with the shards we succeeded on the initial phase. Unfortunately, subsequent phases are not fully detached from the initial phase since they are all non-static inner classes. In future changes this will be changed to detach the inner classes to test them in isolation and to simplify their creation. The AbstractSearchAsyncAction should be final and it should just get a factory for the next phase instead of requiring subclasses etc.
… an exception we handle it correctly in a streamlined fashion
s1monw
force-pushed
the
refactor_search_phases
branch
from
1628d7c to
b7e53e5
Compare
Contributor
Author
|
@elasticmachine test this please |
1 similar comment
Contributor
Author
|
@elasticmachine test this please |
Contributor
Author
|
@elasticmachine would you mind to f***ing test this at least once? |
s1monw
added a commit
to s1monw/elasticsearch
that referenced
this pull request
Jan 27, 2017
At this point AbstractSearchAsyncAction is just a base-class for the first phase of a search where we have multiple replicas for each shardID. If one of them is not available we move to the next one. Yet, once we passed that first stage we have to work with the shards we succeeded on the initial phase. Unfortunately, subsequent phases are not fully detached from the initial phase since they are all non-static inner classes. In future changes this will be changed to detach the inner classes to test them in isolation and to simplify their creation. The AbstractSearchAsyncAction should be final and it should just get a factory for the next phase instead of requiring subclasses etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this point AbstractSearchAsyncAction is just a base-class for the first phase of a search where we have multiple replicas
for each shardID. If one of them is not available we move to the next one. Yet, once we passed that first stage we have to work with
the shards we succeeded on the initial phase.
Unfortunately, subsequent phases are not fully detached from the initial phase since they are all non-static inner classes.
In future changes this will be changed to detach the inner classes to test them in isolation and to simplify their creation.
The AbstractSearchAsyncAction should be final and it should just get a factory for the next phase instead of requiring subclasses
etc.