Skip to content

Conversation

@tlrx
Copy link
Member

@tlrx tlrx commented Jan 11, 2017

This function introduced in #20838 wasn't documented at all.

Related to #22459

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add // CONSOLE here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add // TESTRESPONSE here. Then we'll verify that the snippets do what you say they do.

This function introduced in elastic#20838 wasn't documented at all.

Related to elastic#22459
@tlrx tlrx force-pushed the document-url-mustache-function branch from 99b5a38 to 2f1eb69 Compare January 12, 2017 13:52
@tlrx tlrx merged commit df703dc into elastic:master Jan 12, 2017
tlrx added a commit that referenced this pull request Jan 12, 2017
This function introduced in #20838 wasn't documented at all.

Related to #22459
tlrx added a commit that referenced this pull request Jan 12, 2017
This function introduced in #20838 wasn't documented at all.

Related to #22459
@tlrx tlrx removed the review label Jan 12, 2017
@tlrx
Copy link
Member Author

tlrx commented Jan 12, 2017

Thanks @nik9000

tlrx added a commit that referenced this pull request Jan 12, 2017
This function introduced in #20838 wasn't documented at all.

Related to #22459
@tlrx tlrx deleted the document-url-mustache-function branch January 12, 2017 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >docs General docs changes v5.1.2 v5.2.0 v6.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants