Use tests.asserts flag to allow disabling assertions #22443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Randomized runner uses a flag, tests.asserts, which we have previously not used, but is used in lucene for disabling assertions. This change modifies the gradle configuration to look for this flag and pass through to the test runner to determine whether -ea and -esa are added to the java commandline for tests.
jasontedor
approved these changes
Jan 5, 2017
Member
jasontedor
left a comment
jasontedor
left a comment
There was a problem hiding this comment.
LGTM, although a little piece of me dies every time I see Boolean.parseBoolean.
Member
|
This should go in the 5.1 and 5.2 branches as well as assertions were enabled in standalone integration tests there as well in #22334. |
Member
|
Relates #22390 |
Member
|
retest this please |
rjernst
added a commit
that referenced
this pull request
Jan 6, 2017
Use tests.asserts flag to allow disabling assertions
rjernst
added a commit
that referenced
this pull request
Jan 6, 2017
Use tests.asserts flag to allow disabling assertions
rjernst
added a commit
that referenced
this pull request
Jan 6, 2017
Use tests.asserts flag to allow disabling assertions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Randomized runner uses a flag, tests.asserts, which we have previously
not used, but is used in lucene for disabling assertions. This change
modifies the gradle configuration to look for this flag and pass through
to the test runner to determine whether -ea and -esa are added to the
java commandline for tests.