-
Notifications
You must be signed in to change notification settings - Fork 25.9k
Add basic cgroup CPU metrics #21029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add basic cgroup CPU metrics #21029
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
0df76f0
Add basic cgroup CPU metrics
jasontedor 9a67d4b
Add forbidden API suppressions to cgroup reads
jasontedor c502d6d
Add file permission for /sys/fs/cgroup/cpu/-
jasontedor 65d3df2
Fix method name in OsProbe
jasontedor 5bc48cd
Add Javadocs for basic cgroup stats
jasontedor 5e2b71f
Improve readability of control group matching
jasontedor 8ff1a87
Remove cgroup stats leniency
jasontedor 9f790a7
Handle when cgroups are unavailable in OsStats
jasontedor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we please resolve this in Environment and pass it through via
MonitorService -> OsService -> OsStatsI think we should really try to not usePathUtils.getat all.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be a follow-up? We have to push
Environmentall the way down fromBootstrapbecause we initialize the probes there before the security manager is installed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it can totally be a followup but MonitorService already has it no?