Skip to content

Update description for requests_per_second #20628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
russcam merged 1 commit into from
Jun 14, 2017
Merged

Update description for requests_per_second #20628

russcam merged 1 commit into from
Jun 14, 2017

Conversation

@russcam
Copy link
Contributor

@russcam russcam commented Sep 22, 2016 •
edited
Loading

  • Remove the mention of using 0 to represent no throttle
  • Specify that the float must be greater than 0.

See #20625

@russcam
Update description for requests_per_second
30e49ca 
Remove the mention of using 0 to represent no throttle and specify that the float must be greater than 0.
@russcam russcam mentioned this pull request Sep 22, 2016
Closed
@nik9000 nik9000 added >docs General docs changes :Reindex API v2.4.1 labels Sep 22, 2016
@clintongormley
Copy link
Contributor

clintongormley commented Sep 23, 2016

I thought we removed unlimited? If it is still supported in 2.4, shouldn't we undocument it so that people don't use it?

@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 23, 2017

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@nik9000 nik9000 closed this Feb 27, 2017
@nik9000
Copy link
Member

nik9000 commented Feb 27, 2017

I just checked master and it looks right now.

@nik9000
Copy link
Member

nik9000 commented Feb 27, 2017

As does 5.x

@russcam
Copy link
Contributor Author

russcam commented Feb 27, 2017

@nik9000 this PR is to update the description for 2.4.x which specifies that 0 can be used for no throttle when it can't. The 5.x and master branches have been correct for some time.

@nik9000 nik9000 reopened this Feb 27, 2017
@rjernst
Copy link
Member

rjernst commented Jun 9, 2017

@clintongormley Do we still auto rebuild docs for 2.4? Should this be merged?

@clintongormley
Copy link
Contributor

clintongormley commented Jun 12, 2017 •
edited
Loading

@rjernst this PR doesn't affect the docs - it's the REST API spec. I'm OK with merging it

@russcam
Copy link
Contributor Author

russcam commented Jun 14, 2017

Thanks all. I'll merge this in

@russcam russcam merged commit 67403ea into 2.4 Jun 14, 2017
@lcawl lcawl added :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. and removed :Reindex API labels Feb 13, 2018
@colings86 colings86 deleted the russcam-patch-2.4.0-reindex-rethrottle branch May 27, 2020 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nik9000 nik9000 nik9000 approved these changes

Assignees

No one assigned

Labels

:Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. >docs General docs changes v2.4.2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@russcam @clintongormley @elasticmachine @nik9000 @rjernst @lcawl