Remove payload option from completion suggester#19877
Conversation
The payload option was introduced with the new completion suggester implementation in v5, as a stop gap solution to return additional metadata with suggestions. Now we can return associated documents with suggestions (elastic#19536) through fetch phase using stored field (_source). The additional fetch phase ensures that we only fetch the _source for the global top-N suggestions instead of fetching _source of top results for each shard.
3db40c0 to
d107141
Compare
|
LGTM for the removal. |
I wish we could turn that off too.... It'd be nice not to have to go to stored fields at all sometimes. If you only want doc_values fields it is lame you still need to go get _id from stored fields. |
|
Thanks for the review and suggestion ;) @jimferenczi and @nik9000! I agree it would be nice if we could turn off retrieving the |
The payload option was introduced with the new completion
suggester implementation in v5, as a stop gap solution
to return additional metadata with suggestions.
Now we can return associated documents with suggestions
(#19536) through an additional fetch phase using stored
field (_source). The fetch phase ensures that we only fetch
the _source for the global top-N suggestions instead of
fetching _source of top results for each shard.