Merged
Conversation
areek
added
>breaking
review
:Search Relevance/Suggesters
Member
|
Seems like the right thing to do to me. I know @jasontedor 's looked at the thread pool construction code recently and can probably do a better review than I can. |
Contributor
|
LGTM |
In elastic#17198, we removed suggest transport action, which used the `suggest` threadpool to execute requests. Now `suggest` threadpool is unused and suggest requests are executed on the `search` threadpool.
areek
force-pushed
the
cleanup/remove_suggest_treadpool
branch
from
d19edd9 to
e16e113
Compare
Member
|
LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #17198, we removed suggest transport action, which
used the
suggestthreadpool to execute requests. Nowsuggestthreadpool is unused and suggest requests areexecuted on the
searchthreadpool.