Make security non-optional #16176
Merged
Make security non-optional #16176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintongormley
added
the
:Delivery/Packaging
Contributor
|
+1 |
Member
|
LGTM |
Contributor
|
@s1monw You'll want to make the appropriate changes here too: https://github.com/elastic/elasticsearch/blob/master/docs/reference/modules/scripting/security.asciidoc#disable-the-java-security-manager |
s1monw
force-pushed
the
make_security_non_optional
branch
from
93d3ee3 to
67a5655
Compare
Contributor
Author
|
@clintongormley can you take another look? |
Contributor
|
LGTM |
s1monw
force-pushed
the
make_security_non_optional
branch
from
67a5655 to
36f134e
Compare
2.x has show so far that running with security manager is the way to go. This commit make this non-optional. Users that need to pass their own rules can still do this via the system configuration for the security manager. They can even opt out of all security that way.
s1monw
force-pushed
the
make_security_non_optional
branch
from
36f134e to
c505865
Compare
Contributor
|
Cool, thanks! :) |
jasontedor
added a commit
that referenced
this pull request
Jan 13, 2017
We have made the security manager non-optional, but the Javadocs for Security.java imply that it still is. This commit fixes this issue. Relates #16176
jasontedor
added a commit
that referenced
this pull request
Jan 13, 2017
We have made the security manager non-optional, but the Javadocs for Security.java imply that it still is. This commit fixes this issue. Relates #16176
jasontedor
added a commit
that referenced
this pull request
Jan 13, 2017
We have made the security manager non-optional, but the Javadocs for Security.java imply that it still is. This commit fixes this issue. Relates #16176
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.x has show so far that running with security manager is the way to go.
This commit make this non-optional. Users that need to pass their own rules
can still do this via the system configuration for the security manager. They
can even opt out of all security that way.