Reverted new completion suggester#16170
Closed
colings86 wants to merge 1 commit intoelastic:2.2from
colings86:revert/newCompletionSuggester
Closed
Reverted new completion suggester#16170colings86 wants to merge 1 commit intoelastic:2.2from colings86:revert/newCompletionSuggester
colings86 wants to merge 1 commit intoelastic:2.2from
colings86:revert/newCompletionSuggester
Conversation
The new completion suggester is a breaking change that we should not introduce in a minor version. Instead it will be introduced in version 3.0
colings86
added
review
:Search Relevance/Suggesters
Contributor
Author
|
merged into 2.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new completion suggester is a breaking change that we should not introduce in a minor version. Instead it will be introduced in version 3.0