Restore chunksize of 512kb on recovery and remove configurability #15235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1monw
added
>breaking
review
:Core/Infra/Settings
Contributor
There was a problem hiding this comment.
new ByteSizeValue("512kb").bytes() 
Contributor
Author
There was a problem hiding this comment.
fucking returns a stupid long I don't wanna cast
Contributor
|
Production code LGTM. I left some concerns about the testing change. |
This commit restores the chunk size of 512kb lost in a previous but unreleased refactoring. At the same time it removes the configurability of: * `indices.recovery.file_chunk_size` - now fixed to 512kb * `indices.recovery.translog_ops` - removed without replacement * `indices.recovery.translog_size` - now fixed to 512kb * `indices.recovery.compress` - file chunks are not compressed due to lucene's compression but translog operations are. The compress option is gone entirely and compression is used where it makes sense. On sending files of the index we don't compress as we rely on the lucene compression for stored fields etc. Relates to elastic#15161
s1monw
force-pushed
the
remove_recovery_settings
branch
from
09bd792 to
37b60bd
Compare
Contributor
Author
|
@bleskes I had to add one more commit - can you take a quick look? |
Contributor
|
LGTM |
…for closing streams to not hide original exception
Contributor
Author
|
@bleskes I refined this change one more time to allow tests to override the chunksize which I think is a good tool to have (pkg private setter) and I also fixed the stream closing issue. I think it's ready now. Do you wanna take one more look? |
Contributor
There was a problem hiding this comment.
add comment about what this is not final (i.e., for testing)
Contributor
Author
There was a problem hiding this comment.
the setter has a comment
Contributor
|
LGTM (better than before). left some minor optional suggestions. |
s1monw
added a commit
that referenced
this pull request
Dec 11, 2015
Restore chunksize of 512kb on recovery and remove configurability
clintongormley
removed
the
:Distributed Indexing/Recovery
alamzeeshan
added a commit
to alamzeeshan/elasticsearch
that referenced
this pull request
Jan 31, 2017
Updated document as per this change : elastic#15235
clintongormley
pushed a commit
that referenced
this pull request
Jan 31, 2017
Updated document as per this change : #15235
clintongormley
pushed a commit
that referenced
this pull request
Jan 31, 2017
Updated document as per this change : #15235
clintongormley
pushed a commit
that referenced
this pull request
Jan 31, 2017
Updated document as per this change : #15235
clintongormley
pushed a commit
that referenced
this pull request
Jan 31, 2017
Updated document as per this change : #15235
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit restores the chunk size of 512kb lost in a previous but unreleased
refactoring. At the same time it removes the configurability of:
indices.recovery.file_chunk_size- now fixed to 512kbindices.recovery.translog_ops- removed without replacementindices.recovery.translog_size- now fixed to 512kbindices.recovery.compress- file chunks are not compressed due to lucene's compression but translog operations are.The compress option is gone entirely and compression is used where it makes sense. On sending files of the index
we don't compress as we rely on the lucene compression for stored fields etc.
Relates to #15161