Skip to content

[TEST] Fix version check in testSequenceNumbersDisabled#145879

Merged
kkrik-es merged 13 commits intoelastic:mainfrom
kkrik-es:tsdb/fix-seqno
Apr 8, 2026
Merged

[TEST] Fix version check in testSequenceNumbersDisabled#145879
kkrik-es merged 13 commits intoelastic:mainfrom
kkrik-es:tsdb/fix-seqno

Conversation

@kkrik-es
Copy link
Copy Markdown
Member

@kkrik-es kkrik-es commented Apr 8, 2026

A new version was added for guarding disabled sequence numbers, after removing the feature flag.

Fixes #145864

@kkrik-es
Copy link
Copy Markdown
Member Author

kkrik-es commented Apr 8, 2026

Hm not sure if this is the right fix, lemme take another look.

@kkrik-es kkrik-es changed the title Replace remaining uses of IndexVersions.TIME_SERIES_DISABLE_SEQUENCE_NUMBERS Check version DISABLE_SEQUENCE_NUMBERS in IndexMetadata Apr 8, 2026
@kkrik-es kkrik-es changed the title Check version DISABLE_SEQUENCE_NUMBERS in IndexMetadata [TEST] Fix version check in testSequenceNumbersDisabled Apr 8, 2026
@kkrik-es kkrik-es added >test Issues or PRs that are addressing/adding tests auto-backport Automatically create backport pull requests when merged v9.4.0 v9.5.0 and removed >non-issue labels Apr 8, 2026
@kkrik-es kkrik-es marked this pull request as ready for review April 8, 2026 14:51
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

Copy link
Copy Markdown
Contributor

@fcofdez fcofdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kkrik-es kkrik-es merged commit 8fa1d5c into elastic:main Apr 8, 2026
35 checks passed
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

💔 Backport failed

Status Branch Result
9.5 The branch "9.5" is invalid or doesn't exist

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 145879

szybia added a commit to szybia/elasticsearch that referenced this pull request Apr 8, 2026
* upstream/main:
  Mute org.elasticsearch.xpack.esql.expression.function.aggregate.FirstDocIdGroupingAggregatorFunctionTests testSimple elastic#145923
  Reindex relocation: store source TaskResult at destination node (elastic#145488)
  Bump versions after 9.2.8 release
  [CI] DLMFrozenTransitionServiceTests testCheckForFrozenIndicesReturnsEarlyWhenCapacityExhausted failing [elastic#145778] (elastic#145906)
  Update branches.json for 9.2.8 release
  ESQL: Clarify inheriting from Attributes (elastic#145898)
  Bump versions after 9.3.3 release
  Update branches.json for 9.3.3 release
  Prune changelogs after 8.19.14 release
  Bump versions after 8.19.14 release
  Update branches.json for 8.19.14 release
  [ML] Call old inference API (elastic#145690)
  ESQL: Unmute CsvIT sumWithOverflowRow (elastic#145893)
  Index a document when testing runtime fields shadowing dimensions & metrics (elastic#145882)
  [TEST] Fix version check in testSequenceNumbersDisabled (elastic#145879)
  [ESQL] Per-file filter pushdown awareness (elastic#145755)
  Unmute testGetReindexFollowsRelocation (elastic#145841)
  Correctly ignore system indices when validating dot-prefixed indices (elastic#128868)
  [Transform] Remove tests for deleted code (elastic#145685)
  ESQL: Add generative tests for LIMIT BY (elastic#144238)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged backport pending :StorageEngine/TSDB You know, for Metrics Team:StorageEngine >test Issues or PRs that are addressing/adding tests v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] IndexMetadataTests testSequenceNumbersDisabled failing

3 participants